Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turf.invariant fails on string value as coordinate #643

Merged
merged 3 commits into from
Apr 3, 2017
Merged

Turf.invariant fails on string value as coordinate #643

merged 3 commits into from
Apr 3, 2017

Conversation

ingalls
Copy link
Member

@ingalls ingalls commented Apr 3, 2017

Turf.invariant fails with a Max Callstack Exceeded when a string value is in the coordinates array.

cc/ @DenisCarriere @morganherlocker

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Have read How To Contribute.
  • Run npm test at the sub modules where changes have occurred.
  • Run npm run lint to ensure code style at the turf module level.

@DenisCarriere
Copy link
Member

👍 Awesome! Thanks @ingalls !

@DenisCarriere DenisCarriere merged commit fe1f2c4 into master Apr 3, 2017
@DenisCarriere
Copy link
Member

Ops, forgot to update the turf-invariant/index.d.ts 43094f8 (build passes now)

Merged without waiting for TravisCI 🤓

@ingalls ingalls deleted the recursive-invariant branch April 3, 2017 20:34
@DenisCarriere DenisCarriere added this to the 4.1.0 milestone Apr 9, 2017
@DenisCarriere DenisCarriere mentioned this pull request Apr 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ingalls @DenisCarriere