Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 3-arg rand to AbstractPPL 0.5.x #80

Merged
merged 6 commits into from
Feb 25, 2023
Merged

Conversation

sunxd3
Copy link
Collaborator

@sunxd3 sunxd3 commented Feb 25, 2023

rand defaults have been added since AbstractPPL v0.6.2 (#79), backporting to v0.5 for compatibility.

@sunxd3 sunxd3 requested a review from yebai February 25, 2023 15:54
@yebai
Copy link
Member

yebai commented Feb 25, 2023

Thanks, @sunxd3 -- it looks good; feel free to merge once CI passes.

@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (releases-0.5.x@d6d898b). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                @@
##             releases-0.5.x      #80   +/-   ##
=================================================
  Coverage                  ?   81.02%           
=================================================
  Files                     ?        3           
  Lines                     ?      274           
  Branches                  ?        0           
=================================================
  Hits                      ?      222           
  Misses                    ?       52           
  Partials                  ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devmotion
Copy link
Member

For future backports, a common approach (that we use e.g. also in SpecialFunctions) is to cherry-pick the relevant commit. See e.g. https://github.com/JuliaLang/julia/blob/a77ba79855f400420ccaa09c153ecec2784e386e/doc/src/devdocs/build/distributing.md#cherry-picking-commits for an explanation. The advantage is that one can then resolve conflicts similar to merges and git copies information such as the original commit message and contributors.

@sunxd3
Copy link
Collaborator Author

sunxd3 commented Feb 25, 2023

The changes were done by local git cherry-pick, somehow the original commit information was lost still, I'll verify next time.

@sunxd3 sunxd3 merged commit 7d78781 into releases-0.5.x Feb 25, 2023
@sunxd3 sunxd3 deleted the backport-3-arg-rand branch February 25, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants