Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rstar tests #393

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Update rstar tests #393

merged 2 commits into from
Dec 14, 2022

Conversation

sethaxen
Copy link
Member

TuringLang/MCMCDiagnosticTools.jl#52 updated rstar to by default split the chains in two to test for within-chain convergence. This causes the final rstar test to fail, so this PR updates the test to explicitly use no splitting.

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 83.67% // Head: 83.76% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (7587cb1) compared to base (5f59160).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   83.67%   83.76%   +0.09%     
==========================================
  Files          19       19              
  Lines        1035     1035              
==========================================
+ Hits          866      867       +1     
+ Misses        169      168       -1     
Impacted Files Coverage Δ
src/MCMCChains.jl 100.00% <ø> (+50.00%) ⬆️
src/discretediag.jl 100.00% <ø> (ø)
src/ess.jl 100.00% <100.00%> (ø)
src/gelmandiag.jl 100.00% <100.00%> (ø)
src/rstar.jl 100.00% <100.00%> (ø)
src/utils.jl 95.29% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sethaxen sethaxen merged commit 8c3f5ed into master Dec 14, 2022
@sethaxen sethaxen deleted the updaterstartest branch December 14, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants