Support for custom serializers #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turnerj
force-pushed
the
full-custom-serialization
branch
from
7674da4
to
fd46d4c
Compare
Turnerj
changed the title
Turnerj
force-pushed
the
full-custom-serialization
branch
from
fd46d4c
to
c5f84cf
Compare
We aren't reading the file here, only writing and never appending.
Must have missed it when copying code around in a previous commit
The caching system doesn't need them. This is a breaking change for any file caches that already existed.
This is to primarily satisfy Newtonsoft.Json serialization. In another PR, this will likely be replaced with a static method amongst other changes.
This is just a temporary measure for this PR
This is to hopefully support C# 10 features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should complete support for BYO cache serializers across the whole repo and extends the effort from #159.
JsonFileCacheLayerandProtobufFileCacheLayerare both now obsolete and just pass through the appropriate serializerFileCacheLayerBaseis nowFileCacheLayerand takes anICacheSerializerin its constructorRedisCacheLayernow usesCacheEntry<T>directly with the serializerNote: The JSON serializer no longer does wrapping of the serialized data. I'm not sure if that is a problem or not as I can't find exactly why I did it. I imagine it related to how
nulldata was represented but not 100% sure. Will need further investigation.Closes #158
Blocked by protobuf-net/protobuf-net#802