Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move whois to client pkg, impl caching and update DNS used for tests #366

Merged
merged 5 commits into from
Nov 16, 2022

Conversation

TwiN
Copy link
Owner

@TwiN TwiN commented Nov 16, 2022

Summary

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Added the documentation in README.md, if applicable.

@TwiN TwiN changed the title Refactor/client refactor: Move whois to client package and implement caching Nov 16, 2022
@TwiN TwiN added the dependencies Pull requests that update a dependency file label Nov 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Base: 82.02% // Head: 81.88% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (8e89851) compared to base (861c443).
Patch coverage: 64.51% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage   82.02%   81.88%   -0.14%     
==========================================
  Files          54       54              
  Lines        4028     4047      +19     
==========================================
+ Hits         3304     3314      +10     
- Misses        569      576       +7     
- Partials      155      157       +2     
Impacted Files Coverage Δ
core/endpoint.go 74.57% <33.33%> (-1.36%) ⬇️
client/client.go 58.26% <70.83%> (+2.92%) ⬆️
config/config.go 73.82% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TwiN TwiN changed the title refactor: Move whois to client package and implement caching refactor: Move whois to client pkg, impl caching and update DNS used for tests Nov 16, 2022
@TwiN TwiN marked this pull request as ready for review November 16, 2022 02:50
@TwiN TwiN merged commit eb4e22e into master Nov 16, 2022
@TwiN TwiN deleted the refactor/client branch November 16, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants