Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerting): Add Pushover sound support #417

Merged
merged 1 commit into from
Feb 6, 2023
Merged

feat(alerting): Add Pushover sound support #417

merged 1 commit into from
Feb 6, 2023

Conversation

bakito
Copy link
Contributor

@bakito bakito commented Feb 1, 2023

Summary

In extension to #405 (#129) this PR adds support to configure sound for Pushover.
https://pushover.net/api#sounds

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Added the documentation in README.md, if applicable.

@codecov-commenter
Copy link

Codecov Report

Base: 82.05% // Head: 82.06% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (e6c9a56) compared to base (277e805).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   82.05%   82.06%           
=======================================
  Files          56       56           
  Lines        4225     4226    +1     
=======================================
+ Hits         3467     3468    +1     
  Misses        590      590           
  Partials      168      168           
Impacted Files Coverage Δ
alerting/provider/pushover/pushover.go 86.66% <100.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@TwiN TwiN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!
Thank you for the contribution!

@TwiN TwiN merged commit 9e20069 into TwiN:master Feb 6, 2023
@bakito bakito deleted the sound-for-pushover branch February 24, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants