Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewing threads/answers stopped working at start of June #1181

Closed
5 of 14 tasks
fanf opened this issue Jun 5, 2019 · 34 comments
Closed
5 of 14 tasks

Viewing threads/answers stopped working at start of June #1181

fanf opened this issue Jun 5, 2019 · 34 comments

Comments

@fanf
Copy link

fanf commented Jun 5, 2019

Expected behavior

When viewing a tweet with answers (or part of a thread), view the answers.

Actual behavior

Only one tweet is displayed, the one you clicked on from the timeline.

This is critical and most likely a showstopper for most people.

Steps to reproduce

  • be after 2019-06-01

Timeline => clik on a tweet with answers => only the clicked tweet is displayed.

Extra info

Of course, this used to worked, and twitter changed something and it broke.
It stopped somewhere between 2019-06-01 and 2019-06-02 (certainly depending on some timezone).

Also, I first tried to logout - wait - login again the account, believing it was some kind of threshold. People, don't do that: you won't be able to reconnect easely with official keys (see comments at the end of https://gist.github.com/mariotaku/5465786)

Android version: (version code here)
3.7.3

Network type:

  • Cellular
  • Wi-Fi

App version: (version code here)

Build variant:

  • Google
  • F-Droid

Micro-blogging service:

  • Twitter
  • Fanfou
  • GNU Social / StatusNet
  • Mastodon

App settings:

  • Custom API
  • Custom consumer key/secrets
  • Official keys
  • Using Thumbor
  • Connected through proxy
  • Media preview enabled
@svil3
Copy link

svil3 commented Jun 5, 2019

Can confirm this "bug" too.
And can confirm it isn't the keys since all the other features that only work with official ones are still there.

@flipsa
Copy link

flipsa commented Jun 5, 2019

Same here.

@ashrafammar
Copy link

I was facing the same issue. I deleted the cache and login details and re-logged in. Used Android Consumer Key but I can see the replies cannot see who likes my tweets.
Does anyone know how to solve it? It seems developer is not going to update it anymore

@fanf
Copy link
Author

fanf commented Jun 6, 2019

@ashrafammar the fact that you can't see mentions let me believe that the official keys where not taken in account (Twitter changed login process and you can't use official keys without editing android accounts DB, see gist link comments for "official keys").

It also seems to mean that now, Twitter behave differently for threads / comments with officials / non officials keys. What a mess.
others clients seems to be affected too: owly displays answers but not threads for ex.

And regarding twidere authors, je said that he could have some time for twidere this year contrary to last one. He still use Twitter, hopefully through twidere, so maybe he is also impacted and the pb is sufficiently disrupting that he wants to correct it asap.

@WPettersson
Copy link

WPettersson commented Jun 6, 2019

I realise that logging out/in means official keys won't work (easily), so be careful if you try this, but has anyone tried reverting to the original Twidere API keys, and do those still load replies properly?

As a possibly-relevant sidenote, the account twitter.com/twidere has been suspended. I do think that was the official account for this project, no idea if the suspension is relevant.

Edit: Ignore above, as fanf points out below this is wrong. My bad.

@fanf
Copy link
Author

fanf commented Jun 6, 2019

Twidere twitter account is: https://twitter.com/@twidereproject (and his author: https://twitter.com/mariotaku)

@LukeDuckwalker
Copy link

Same issue for me.

@Torvin
Copy link
Contributor

Torvin commented Jun 9, 2019

This endpoint now returns 404: https://api.twitter.com/1.1/conversation/show.json. That's why tweets no longer load with official keys. The only thing you can do now is switching to non-official keys until this is fixed in the Twidere's code

@Torvin
Copy link
Contributor

Torvin commented Jun 9, 2019

I believe the official Twitter client is now sending this GET request:

https://api.twitter.com/2/timeline/conversation/{{ID}}.json?&earned=true&include_entities=true&include_cards=true&cards_platform=Android-12&include_carousels=true&ext=mediaRestrictions%2CaltText%2CmediaStats%2CmediaColor%2Cinfo360%2CcameraMoment%2Cmaster_playlist_only&include_media_features=true&include_blocking=true&include_blocked_by=true&tweet_mode=extended&include_reply_count=true&include_composer_source=true&simple_quoted_tweet=true&include_ext_media_availability=true&include_user_entities=true&include_profile_interstitial_type=true

If the response format is the same, it should be a trivial fix

@fanf
Copy link
Author

fanf commented Jun 9, 2019 via email

@ZaZo0o
Copy link

ZaZo0o commented Jun 16, 2019

I confirm the issue with tje official Twitter for android keys.
And when I log in using the default twidere keys I can see the replies again, but not the notifications...

@jomo
Copy link

jomo commented Jun 19, 2019

FYI: If you want to switch to Twidere keys as a workaround, you can simply add the account again (select Twitter → Twitter). Twidere will say you're already authorized, but switch API keys.

@Torvin
Copy link
Contributor

Torvin commented Jun 20, 2019

Unfortunately, looks like the new response format from /2/timeline/conversation/{{ID}}.json is quite different, so it's not going to be an easy change. So instad I made a workaround that falls back to the 'non-official' API endpoint to read conversations. See #1184

@mariotaku, please, if you have time, accept it!

mariotaku added a commit that referenced this issue Jun 26, 2019
@mariotaku
Copy link
Member

Since there're some build errors to be fixed, I'll be publishing this version to Google Play on Friday night.
Current code base is too old, I'm starting to maintain current situation only and exploring new possibility, like to build a new one with 100% Kotlin, or Flutter.

@mariotaku
Copy link
Member

By the way thank you so much to contribute to Twidere! @Torvin

@fsyhrnl
Copy link

fsyhrnl commented Jun 28, 2019

Viewing threads/answers stopped working at start of June?
no! I experienced it from 2018 !

@ashrafammar
Copy link

The app updated but still facing the same issues

@WPettersson
Copy link

Will the new version be uploaded to f-droid as well?

@Torvin
Copy link
Contributor

Torvin commented Jun 30, 2019

@WPettersson F-droid maintainers do that by themselves, you cannot control that. Usually it takes them some time.

@fanf
Copy link
Author

fanf commented Jun 30, 2019

I updated to version 3.7.3 and deleted my previous account, then try to connect with xauth+Twitter official keys.
It worked.
I get notification and private messages, but still no answers in conversation.
Did someone had it working? What did you do?

@Torvin
Copy link
Contributor

Torvin commented Jun 30, 2019

I updated to version 3.7.3 and deleted my previous account, then try to connect with xauth+Twitter

It was fixed in 3.7.4. You need to wait for it to become available on Play Store / F-droid.

@fanf
Copy link
Author

fanf commented Jun 30, 2019

@Torvin: oh thanks, I misunderstood in what version it was corrected.

@fanf
Copy link
Author

fanf commented Jun 30, 2019

OK, I installed 3.7.4 from the release page on github and I have access back to thread, thank you

@Torvin
Copy link
Contributor

Torvin commented Jul 1, 2019

OK, I installed 3.7.4 from the release page on github and I have access back to thread, thank you

@mariotaku should we close this issue? or do you want to look into using the new API endpoint?

@igalic
Copy link

igalic commented Jul 5, 2019

i've tried doing the same thing, however, my accounts are protected with 2FA, and it doesn't work for me — neither sign in, nor password sign in:

after my login attempts i get an SMS with a temporary password, but again, no matter where i try to plug that in, it does log me in.
I only get a 401 Error again

@WPettersson
Copy link

@igalic What do you mean by "doing the same thing"? If you've left your account as-is, with the Twitter API keys, then it should still be logged in, and not require any new login.

If you you need to login, however, then I've heard of people not being able to log in with the official twitter API keys. If that's the case, I'd suggest opening a new issue, as it's a different issue.

@igalic
Copy link

igalic commented Jul 5, 2019

@WPettersson i did the exact same procedure (with 3.7.4) that (mostly) worked for @fanf:

I updated to version 3.7.3 and deleted my previous account, then try to connect with xauth+Twitter official keys.
It worked.
I get notification and private messages, but still no answers in conversation.
Did someone had it working? What did you do?

@hkramski
Copy link

hkramski commented Jul 8, 2019

I have GitHub version 3.7.4 fully working here after

  • deinstalling existing 3.7.3 (otherwise the GitHub .apk did not install)
  • installing 3.7.4 from GitHub
  • setting Consumer key: 3nVuSoBZnx6U4vzUxf5w from https://gist.github.com/mariotaku/5465786
  • setting "Authentifizierungstyp" to "xAuth" (in German, sorry)

@igalic
Copy link

igalic commented Jul 8, 2019

@hkramski do your accounts have 2FA enabled?

@hkramski
Copy link

hkramski commented Jul 9, 2019

@hkramski do your accounts have 2FA enabled?

No.

@fsyhrnl
Copy link

fsyhrnl commented Jul 9, 2019

viewing thread/answer stuck when 20 replies, i using official api key

@Torvin
Copy link
Contributor

Torvin commented Jul 9, 2019

viewing thread/answer stuck when 20 replies, i using official api key

I don't think it is exactly 20. The exact number will vary from thread to thread, but you won't be able to see all the replies anymore. That's the current limitation.

@Torvin
Copy link
Contributor

Torvin commented Aug 19, 2019

This is also occurring for me with Mastodon. It is not a Twitter exclusive issue.

I don't think it's related. Please open a separate issue with all the relevant information you can provide

@Tedko
Copy link
Contributor

Tedko commented Apr 20, 2020

Hi - with 4.0.8 we fixed the problem with new logins and we have some basic func of DM working.

For reply flow. we're working on a fix. ( #1231 )

@Torvin @fanf
Just let you know now twidere is maintained by community and supported by Dimension.im -- we're looking for more community contributor as well. Pls spread the words. Thx

@Tedko Tedko closed this as completed Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests