Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for #1181 #1184

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Temporary fix for #1181 #1184

merged 2 commits into from
Jun 26, 2019

Conversation

Torvin
Copy link
Contributor

@Torvin Torvin commented Jun 20, 2019

This pull request makes Twidere fall back to non-official keys approach to reading conversation threads, since the 'official' endpoint for this was apparently removed in API v1.1

I was originally planning to base these changes on develop, but unfortunately it's half broken - most screens in settings just make the app crash. So it's based on the last stable version instead (master).

I also had to upgrade Kotlin version since the latest Android Studio refused to build master. I did that in a separate commit for clarity.

@cla-bot
Copy link

cla-bot bot commented Jun 20, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don"t seem to have the users @Torvin on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@mariotaku mariotaku changed the base branch from master to maintenance June 26, 2019 05:00
@mariotaku mariotaku merged commit 1ba3bca into TwidereProject:maintenance Jun 26, 2019
@GranPC
Copy link
Contributor

GranPC commented Jul 2, 2019

Thanks for fixing this :)

@LukeDuckwalker
Copy link

I understood that this problem is fixed with the 3.7.4 release, but Google Play Store version is at 3.7.3.
I'm sorry to bother but I don't know what to do. How can I get 3.7.4? Should I wait a release on the Play Store?
Thanks in advance

@GranPC
Copy link
Contributor

GranPC commented Jul 4, 2019

It's rolling out, I received the update a couple of days ago. Patience is key!

@mariotaku
Copy link
Member

Found several crashes. So I'm gonna fix crash issues and release another version.

@LukeDuckwalker
Copy link

Ok, thanks a lot for the explanation. I'll wait! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants