This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Resolve issues#13 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve issues#13
mcelicalderon
suggested changes
Oct 6, 2016
| @@ -137,7 +137,7 @@ private function _findOrCreateCallTrackingApp() | |||
| "friendlyName" => 'Call tracking app' | |||
| ) | |||
| ); | |||
| if ($existingApp) { | |||
| if (count($existingApp)) { | |||
There was a problem hiding this comment.
Hey @itsazzad ! #13 Was already resolved in #14 . This change you are introducing shouldn't make any difference as an empty array will be evaluated as false just as much as a 0 that you get from counting said array. But, I would actually like to be more explicit here and replace that expression with
if (count($existingApp) > 0) {
If you wouldn't mind making that change, I'd be happy to merge your PR. And we have the exact same expression here that I think was also introduced by you.
Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issues#13