This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
Changes callbacks to method calls in controller actions. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a personal preference, but one that I believe many other developers are following too. Callbacks on models can hide the complexity that is happening in a controller action. Making the calls explicitly within the action shows exactly what that action is up to. Other things this helps with are tests or admin actions, where you don't get unintended side effects if you create an object outside of its normal life. There are some blog posts on this, for example [here](http://adequate.io/culling-the-activerecord-lifecycle) and [here](https://www.reinteractive.net/posts/130-activerecord-callbacks-considered-harmful).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a personal preference, but one that I believe many other developers are
following too. Callbacks on models can hide the complexity that is happening in
a controller action. Making the calls explicitly within the action shows exactly
what that action is up to. Other things this helps with are tests or admin
actions, where you don't get unintended side effects if you create an object
outside of its normal life. There are some blog posts on this, for example
here and here.