Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved toasts to top-center & changed duration to 1 sec #107

Merged
merged 2 commits into from
Sep 29, 2020

Conversation

phoward38
Copy link
Contributor

Are you getting these notes from devtools::check:

> checking package dependencies ... NOTE
  Imports includes 22 non-default packages.
  Importing from so many packages makes the package vulnerable to any of
  them becoming unavailable.  Move as many as possible to Suggests and
  use conditionally.

> checking for future file timestamps ... NOTE
  unable to verify current time

Copy link
Collaborator

@merlinoa merlinoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would define the toast options in 1 location so that you don't need to repeat them over and over. Also 1 second is much faster than our current showDuration which I think is either 3 or 4 seconds. Did you test the show duration?

@phoward38
Copy link
Contributor Author

@merlinoa

  • I was thinking the same but wasn't sure where to put the toast options
  • Yea I tested it. Our show duration is 0.3 seconds by default in showToast

@merlinoa
Copy link
Collaborator

merlinoa commented Sep 29, 2020

You can put the toast options in "utils.R". Use @noRd and don't export them.

It seemed like our prior default was a lot longer than 0.3 seconds, but I guess it was the fadein and fadeout time. Anyways update the toast options and I'll check it out real quick. Thanks.

@merlinoa
Copy link
Collaborator

Awesome! looks good.

@merlinoa merlinoa merged commit d82ad41 into master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants