Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TD-918]: Implementing releng bundle using gromit policy with multiple version support. #26

Merged
merged 21 commits into from Aug 2, 2022
Merged

[TD-918]: Implementing releng bundle using gromit policy with multiple version support. #26

merged 21 commits into from Aug 2, 2022

Conversation

asutosh
Copy link
Contributor

@asutosh asutosh commented Jun 16, 2022 •
edited

This PR will

  • Translate the m4 templates to go templates for direct rendering of releng code with gromit policy.
  • Will add support for multiple versions(from within the templates) => To be done in a subsequent PR.

@asutosh
Added skeleton goreleaser template and dir rendering.
167d05f 
For files that can have multiple components, there can be a dir
named `<file>.d` that can contain template definitions for the file.
All of this would be rendered together.
@asutosh asutosh requested a review from alephnull June 16, 2022 12:56
@alephnull
Copy link
Contributor

This approach is fine. We'll have to fix the tests though. I'll work on applying auth from TD-1025 in this PR.

@alephnull alephnull removed their request for review June 20, 2022 06:01
@asutosh asutosh marked this pull request as ready for review June 22, 2022 18:05
@asutosh
Copy link
Contributor Author

asutosh commented Jun 22, 2022

All the files managed by tyk-ci except the goreleaser-el7.yml has been converted to text/template, and is generated for gateway.
Generated test PR is here: tyklabs/tyk#8.

@asutosh asutosh requested a review from alephnull June 22, 2022 18:08
@alephnull
Copy link
Contributor

test PR is here: tyklabs/tyk#8
Please create a PR on TykTechnologies/tyk for testing.

@asutosh
Copy link
Contributor Author

asutosh commented Jun 23, 2022 •
edited

Please create a PR on TykTechnologies/tyk for testing.

Created one here: TykTechnologies/tyk#4148
There seems to be an error in release pipeline - will check and update.

@asutosh
Copy link
Contributor Author

asutosh commented Jun 27, 2022

TykTechnologies/tyk#4157

Release successful in this PR, after the fix above.

@alephnull
Copy link
Contributor

Please update this PR to update Dockerfile.std as suggested by @titpetric in TykTechnologies/tyk#4157
This PR can be merged after TykTechnologies/tyk#4157 is merged.

@asutosh
Added goreleaser el7 templates.
11ea1f8 
In tyk-ci, the el7 templates were managed by a special case for el7 file
in the generation script itself, which avoided having to maintain  a lot of
redundant templates. But here we've offloaded the el7 changes to templates
mainly due to the inability to include templates by calling filenames.
This necessitates keeping some redundant templates, but avoids having to
maintain a special case in the code for `el7` files/templates.
@asutosh
Copy link
Contributor Author

asutosh commented Jul 4, 2022 •
edited

@alephnull I've also added the el7 changes in this PR itself, since it's only a few files, and that will also be needed to merge TykTechnologies/tyk#4157. Will additionally add the latest dockerfile changes.

@alephnull
Copy link
Contributor

Sounds good @asutosh. The plan is,

@asutosh
Update Dockerfile.std template.
bc62a91 
To align with the latest changes - upgrade to bullseye.
@asutosh
Removed static builds from goreleaser.
a9ebc58 
We don't have slim images anymore, so no more static
builds.
@asutosh
Removed static builds from el7 config.
09b54d7
@asutosh
Fix always checking out the default branch.
7b2c6cd 
We always used to checkout  the default branch(master) on
InitGit, but when we want to test making PRs against a release
branch or any other branchm this assumption won't work.
So always checkout the given branch if given branch isn't the
default branch.
@asutosh asutosh changed the title [TD-968]: Implementing releng bundle using gromit policy with multiple version support. [TD-918]: Implementing releng bundle using gromit policy with multiple version support. Jul 14, 2022
alephnull
alephnull approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@alephnull alephnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge when convenient.

@alephnull
Copy link
Contributor

@asutosh Lets setup a pairing session to fix these tests. Since we are going to use gromit in the short-term, these tests need to be fixed.

@asutosh asutosh merged commit 26dd071 into master Aug 2, 2022
@asutosh asutosh deleted the feat/releng-bundle branch August 2, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alephnull alephnull alephnull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@asutosh @alephnull