Better handle unknown errors (#32)

* Better handle unknown errors * Better handle unknown errors#2
TykTechnologies · Aug 10, 2023 · 4643c02 · 4643c02
1 parent 3c06be9
commit 4643c02
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/errors.go b/errors.go
@@ -13,12 +13,17 @@ type APIError struct {
 }
 
 func (e APIError) Error() string {
+	err := "unknown error"
+	if len(e.Errors) != 0 {
+		err = e.Errors[0]
+	}
+
 	return fmt.Sprintf(
 		"%v %v: %v %v",
 		e.Response.Request.Method,
 		e.Response.Request.URL,
 		e.Response.StatusCode,
-		e.Errors[0],
+		err,
 	)
 }
 

diff --git a/portal.go b/portal.go
@@ -467,8 +467,9 @@ func checkError(resp *APIResponse) error {
 		}
 
 		if err := json.Unmarshal(resp.Body, &e); err != nil {
-			return err
+			return errors.New(http.StatusText(resp.Response.StatusCode))
 		}
+
 		return e
 	}
 }