Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-12266] Add Rate Limit Smoothing Docs (5.4.0) #4771

Merged
merged 23 commits into from
Jun 18, 2024

Conversation

titpetric
Copy link
Contributor

@titpetric titpetric commented Jun 10, 2024

User description

For internal users - Please add a Jira DX PR ticket to the subject!


  • Updates rate limiter docs with rate limit smoothing
  • Updates key and policy creation examples documenting the value

Preview Link


Description


Screenshots (if appropriate)


Checklist

  • I have added a preview link to the PR description.
  • I have reviewed the guidelines for contributing to this repository.
  • I have read the technical guidelines for contributing to this repository.
  • Make sure you have started your change off our latest master.
  • I labelled the PR

PR Type

Documentation


Description

  • Added JSON formatting to API key creation examples.
  • Introduced rate limit smoothing configuration in API key creation and security policy creation.
  • Updated explanations and examples for new fields in API key creation and security policy creation.
  • Added detailed explanation and example configuration for rate limit smoothing in rate limiting concepts.

Changes walkthrough 📝

Relevant files
Documentation
create-api-key.md
Add rate limit smoothing configuration to API key creation

tyk-docs/content/getting-started/create-api-key.md

  • Added JSON formatting to API key creation examples.
  • Introduced rate limit smoothing configuration in API key creation.
  • Updated explanations for new fields in API key creation.
  • +28/-6   
    create-security-policy.md
    Add rate limit smoothing configuration to security policy creation

    tyk-docs/content/getting-started/create-security-policy.md

  • Added rate limit smoothing configuration to security policy creation.
  • Updated rate limit and quota values in policy examples.
  • +17/-9   
    rate-limiting.md
    Add detailed documentation for rate limit smoothing           

    tyk-docs/content/getting-started/key-concepts/rate-limiting.md

  • Added detailed explanation of rate limit smoothing.
  • Provided example configuration for rate limit smoothing.
  • Updated Redis Rate Limiter section with new smoothing options.
  • +55/-2   

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5]

    3

    🧪 Relevant tests

    No

    🔒 Security concerns

    No

    ⚡ Key issues to review

    JSON Formatting:
    The PR adds JSON formatting to the documentation examples. Ensure that the JSON is valid and properly formatted.

    Rate Limit Smoothing:
    The PR introduces documentation for a new feature called "Rate Limit Smoothing". It's crucial to verify the accuracy of the configuration details and their implications.

    Consistency in Documentation:
    Ensure that the terminology and formatting remain consistent throughout the document. Changes like adding periods at the end of sentences for consistency should be checked across all documents.

    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Maintainability
    Add a closing JSON block and triple backticks to properly close the JSON code block

    Ensure that the JSON code block is properly closed with a closing triple backticks () to
    maintain the markdown formatting standards and prevent rendering issues on the
    documentation site.

    tyk-docs/content/getting-started/create-api-key.md [27-30]

     ```json
     {
       "api_model": {},
       "key_id": "59bf9159adbab8abcdefghijac9299a1271641b94fbaf9913e0e048c",
    +}
    +```
     
    Suggestion importance[1-10]: 10

    Why: The suggestion correctly identifies the missing closing brace and triple backticks for the JSON code block, which is crucial for maintaining proper markdown formatting and preventing rendering issues on the documentation site.

    10
    Ensure the JSON code block is properly closed to maintain markdown formatting

    Add a closing triple backticks () after the JSON code block to ensure proper formatting
    and readability in the markdown file.

    tyk-docs/content/getting-started/create-api-key.md [44-49]

     ```json
     {
       "action": "create",
       "key": "c2cb92a78f944e9a46de793fe28e847e",
       "status": "ok"
     }
    +```
     
    Suggestion importance[1-10]: 10

    Why: This suggestion accurately points out the need to close the JSON code block with triple backticks, which is essential for correct markdown rendering and readability.

    10

    Copy link

    netlify bot commented Jun 10, 2024

    PS. Pls add /docs/nightly to the end of url

    Name Link
    🔨 Latest commit 6307096
    🔍 Latest deploy log https://app.netlify.com/sites/tyk-docs/deploys/666759592501e000081e70ca
    😎 Deploy Preview https://deploy-preview-4771--tyk-docs.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link

    netlify bot commented Jun 10, 2024

    PS. Pls add /docs/nightly to the end of url

    Name Link
    🔨 Latest commit e03e18f
    🔍 Latest deploy log https://app.netlify.com/sites/tyk-docs/deploys/6671a0d5c6b37d0008752f37
    😎 Deploy Preview https://deploy-preview-4771--tyk-docs.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Contributor

    @dcs3spp dcs3spp left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @titpetric PRLGTM I have made some minor suggestions. Why the additional spacing in front matter for aliases?

    @dcs3spp
    Copy link
    Contributor

    dcs3spp commented Jun 14, 2024

    @titpetric Is there rate limiting content that needs to be added to Self Managed and Cloud tabs for create security policies and access api keys?

    Copy link
    Contributor

    @andyo-tyk andyo-tyk left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Corrected typos

    tyk-docs/content/getting-started/create-api-key.md Outdated Show resolved Hide resolved
    Copy link
    Contributor

    @andyo-tyk andyo-tyk left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Correcting local links

    Copy link
    Contributor

    @andyo-tyk andyo-tyk left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Recommend not making changes to the getting started guides at this stage.

    @dcs3spp
    Copy link
    Contributor

    dcs3spp commented Jun 18, 2024

    @titpetric I have approved the PR and removed the rate limit smoothing in the examples. @andyo-tyk are you ok with the changes? If so I will merge ready for release

    @jeffy-mathew
    Copy link
    Contributor

    @titpetric @dcs3spp lgtm, I've approved.

    @dcs3spp dcs3spp force-pushed the docs/tt-12266/rate-limit-smoothing branch from 206c4cc to e03e18f Compare June 18, 2024 14:59
    @dcs3spp
    Copy link
    Contributor

    dcs3spp commented Jun 18, 2024

    Many thanks @jeffy-mathew I will merge ready for release

    @dcs3spp dcs3spp merged commit 3cc401d into master Jun 18, 2024
    10 checks passed
    @dcs3spp dcs3spp deleted the docs/tt-12266/rate-limit-smoothing branch June 18, 2024 15:02
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    6 participants