-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-12266] Add Rate Limit Smoothing Docs (5.4.0) #4771
Conversation
6307096
to
9c1bf7c
Compare
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@titpetric PRLGTM I have made some minor suggestions. Why the additional spacing in front matter for aliases?
@titpetric Is there rate limiting content that needs to be added to Self Managed and Cloud tabs for create security policies and access api keys? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correcting local links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend not making changes to the getting started guides at this stage.
35cf25a
to
590c477
Compare
@titpetric I have approved the PR and removed the rate limit smoothing in the examples. @andyo-tyk are you ok with the changes? If so I will merge ready for release |
@titpetric @dcs3spp lgtm, I've approved. |
removed 2 spaces in aliases and unused meta data from the frontmatter.
Long overdue overhaul of the page based on the rate limit smoothing content
Co-authored-by: dcs3spp <dcs3spp@users.noreply.github.com>
Co-authored-by: andyo-tyk <99968932+andyo-tyk@users.noreply.github.com>
206c4cc
to
e03e18f
Compare
Many thanks @jeffy-mathew I will merge ready for release |
User description
For internal users - Please add a Jira DX PR ticket to the subject!
Preview Link
Description
Screenshots (if appropriate)
Checklist
master
.PR Type
Documentation
Description
Changes walkthrough 📝
create-api-key.md
Add rate limit smoothing configuration to API key creation
tyk-docs/content/getting-started/create-api-key.md
create-security-policy.md
Add rate limit smoothing configuration to security policy creation
tyk-docs/content/getting-started/create-security-policy.md
rate-limiting.md
Add detailed documentation for rate limit smoothing
tyk-docs/content/getting-started/key-concepts/rate-limiting.md