-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TN-6] Fix base64 ES decoding #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
/release to release-1.0 |
Working on it! Note that it can take a few minutes. |
@buger Seems like there is conflict and it require manual merge. |
/release to release-1.0 |
Working on it! Note that it can take a few minutes. |
@matiasinsaurralde Seems like there is conflict and it require manual merge. |
Fixing base64 decoding for ElasticSearch
Description
Fixing the base64 decoding for ElasticSearch raw request and response.
Related Issue
Issue #52
Motivation and Context
The config option
decode_base64
for ElasticSearch wasn't working.How This Has Been Tested
Tested with
decode_base64
true and false. It works ok.Screenshots (if appropriate)
Analytic record with
decode_base64
false:Analytic record with
decode_base64
true:Types of changes
Checklist
fork, don't request your
master
!master
branch (left side). Also, you should startyour branch off our latest
master
.go mod tidy && go mod vendor
go fmt -s
go vet