Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TN-6] Fix base64 ES decoding #257

Merged
merged 2 commits into from
Aug 7, 2020
Merged

[TN-6] Fix base64 ES decoding #257

merged 2 commits into from
Aug 7, 2020

Conversation

tbuchaillot
Copy link
Contributor

Fixing base64 decoding for ElasticSearch

Description

Fixing the base64 decoding for ElasticSearch raw request and response.

Related Issue

Issue #52

Motivation and Context

The config option decode_base64 for ElasticSearch wasn't working.

How This Has Been Tested

Tested with decode_base64 true and false. It works ok.

Screenshots (if appropriate)

Analytic record with decode_base64false:
image
Analytic record with decode_base64true:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • [] My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

@tbuchaillot tbuchaillot self-assigned this May 26, 2020
@tbuchaillot tbuchaillot linked an issue May 26, 2020 that may be closed by this pull request
Copy link
Contributor

@matiasinsaurralde matiasinsaurralde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buger buger changed the title Fix base64 ES decoding [TN-6] Fix base64 ES decoding Jul 1, 2020
@matiasinsaurralde matiasinsaurralde merged commit 0adb849 into master Aug 7, 2020
@matiasinsaurralde matiasinsaurralde deleted the fix/base64ES branch August 7, 2020 14:48
@buger
Copy link
Member

buger commented Aug 7, 2020

/release to release-1.0

@tykbot
Copy link

tykbot bot commented Aug 7, 2020

Working on it! Note that it can take a few minutes.

@tykbot
Copy link

tykbot bot commented Aug 7, 2020

@buger Seems like there is conflict and it require manual merge.

@matiasinsaurralde
Copy link
Contributor

/release to release-1.0

@tykbot
Copy link

tykbot bot commented Aug 7, 2020

Working on it! Note that it can take a few minutes.

@tykbot
Copy link

tykbot bot commented Aug 7, 2020

@matiasinsaurralde Seems like there is conflict and it require manual merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raw data is sent in base64 to Elasticsearch
3 participants