TT-12103 Pump FIPS compliant #825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mativm02
commented
May 16, 2024
Comment on lines
+60
to
+62
| echo "Running tests with GOEXPERIMENT=boringcrypto" | ||
| export GOEXPERIMENT=boringcrypto | ||
| show go test -tags=boringcrypto -timeout ${TEST_TIMEOUT} ${race} --coverprofile=${coveragefile}.cov -v ${pkg} |
There was a problem hiding this comment.
At the moment, all the crypto-related functions are within the pumps package, but this test is running over all the packages. Should we run it only for pumps package, or leave it as it is?
This commit updates the Dockerfile.std file by adding the GOEXPERIMENT environment variable. The variable is passed as an argument and set in the environment to enable experimental Go features. This change is made to enhance the build process and enable the use of experimental Go features in the CI environment.
This commit updates the build tag logic in the release workflow. Instead of relying solely on the `github.ref_name` variable, it now checks the value of `github.ref` to determine the appropriate build tag. If the ref starts with `refs/tags/`, it sets the build tag to the tag name. If the ref starts with `refs/pull/`, it sets the build tag to `pr-{pull_request_number}`. Otherwise, it sets the build tag to the commit SHA. This change improves the accuracy of the build tag and ensures it reflects the correct reference type.
This commit updates the build tag logic in the release workflow to improve accuracy and reflect the correct reference type. It now checks the value of `github.ref` to determine the appropriate build tag. If the ref starts with `refs/tags/`, it sets the build tag to the tag name. If the ref starts with `refs/pull/`, it sets the build tag to `pr-{pull_request_number}`. Otherwise, it sets the build tag to the commit SHA.
…gcrypto
This commit updates the build tag logic in the release workflow to include the "boringcrypto" flavor. It modifies the metadata-action step to generate tags with the pattern "v{{major}}.{{minor}}-boringcrypto" and "v{{version}}-boringcrypto" for the "tyk-pump" image. This change ensures that the correct tags are applied to the boringcrypto image during the release process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
Checklist
fork, don't request your
master!masterbranch (left side). Also, you should startyour branch off our latest
master.go mod tidy && go mod vendorgo fmt -sgo vet