Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-12103 Pump FIPS compliant #825

Closed
wants to merge 27 commits into from
Closed
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
0875ad4
adding boringcrypto
mativm02 May 14, 2024
8497730
removing unused binary
mativm02 May 14, 2024
0507b94
adding GOEXPERIMENT
mativm02 May 14, 2024
40d437e
Merge branch 'master' into TT-12103
mativm02 May 16, 2024
8dceb61
improving ci-test.sh
mativm02 May 16, 2024
8b5256d
Merge branch 'TT-12103' of github.com:TykTechnologies/tyk-pump into T…
mativm02 May 16, 2024
8a97e57
adding boringcrypto to goreleaser
mativm02 May 17, 2024
800be75
Merge branch 'master' into TT-12103
mativm02 May 20, 2024
8aea109
commenting new step
mativm02 May 20, 2024
fe76404
Merge branch 'TT-12103' of github.com:TykTechnologies/tyk-pump into T…
mativm02 May 20, 2024
691570c
removing duplicated 'jobs'
mativm02 May 20, 2024
2794b3c
uncommenting job
mativm02 May 20, 2024
400e05f
adding if statement within the same step
mativm02 May 20, 2024
42cab62
chore: Update Dockerfile.std with GOEXPERIMENT environment variable
mativm02 May 20, 2024
f24f28e
formatting
mativm02 May 20, 2024
c66c8ed
formatting 2
mativm02 May 20, 2024
c79fb59
commenting borincrypto
mativm02 May 20, 2024
6d8966b
chore: Update Dockerfile.std with GOEXPERIMENT environment variable
mativm02 May 20, 2024
cf5feba
modifying go_tags to tags
mativm02 May 20, 2024
bed98e3
adding build tag
mativm02 May 20, 2024
c1e90ec
refactor: Update build tag logic in release workflow
mativm02 May 20, 2024
eeac37f
refactor: Update build tag logic in release workflow
mativm02 May 20, 2024
666e3ad
refactor: Improve accuracy of build tag logic in release workflow
mativm02 May 20, 2024
8804bda
refactor: Improve accuracy of build tag logic in release workflow
mativm02 May 20, 2024
fdb5739
refactor: Update build tag logic in release workflow to include borin…
mativm02 May 20, 2024
e77c76c
refactor: Update build tag logic in release workflow to include borin…
mativm02 May 20, 2024
5ee1f94
refactor: Update build tag logic in release workflow to include borin…
mativm02 May 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions bin/ci-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,15 @@ do
for mongo_driver in "${MONGO_DRIVERS[@]}"; do
echo "Running tests with MONGO_DRIVER=$mongo_driver"
export MONGO_DRIVER=$mongo_driver
coveragefile=`echo "$pkg" | awk -F/ '{print $NF}'`
coveragefile=$(echo "$pkg" | awk -F/ '{print $NF}')
show go test -timeout ${TEST_TIMEOUT} ${race} --coverprofile=${coveragefile}.cov -v ${pkg}
done
else
coveragefile=`echo "$pkg" | awk -F/ '{print $NF}'`
coveragefile=$(echo "$pkg" | awk -F/ '{print $NF}')
show go test -timeout ${TEST_TIMEOUT} ${race} --coverprofile=${coveragefile}.cov -v ${pkg}
fi

echo "Running tests with GOEXPERIMENT=boringcrypto"
export GOEXPERIMENT=boringcrypto
show go test -tags=boringcrypto -timeout ${TEST_TIMEOUT} ${race} --coverprofile=${coveragefile}.cov -v ${pkg}
Comment on lines +60 to +62
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, all the crypto-related functions are within the pumps package, but this test is running over all the packages. Should we run it only for pumps package, or leave it as it is?

done
6 changes: 6 additions & 0 deletions pumps/fips.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
//go:build boringcrypto
// +build boringcrypto

package pumps

import _ "crypto/tls/fipsonly"
Loading