Fix max_conn_time

`HTTPTransportCreated` was never set

gateway_test.go

@@ -1150,4 +1150,29 @@ func TestKeepAliveConns(t *testing.T) {
 			{Code: 200},
 		}...)
 	})
+
+	t.Run("Should respect max_conn_time", func(t *testing.T) {
+		config.Global.CloseConnections = false
+		// Allow 2 connection with 2 reads
+		upstream := createTestUptream(t, 2, 2)
+		defer upstream.Close()
+		config.Global.MaxConnTime = 1
+
+		spec := buildAndLoadAPI(func(spec *APISpec) {
+			spec.Proxy.ListenPath = "/"
+			spec.Proxy.TargetURL = "http://" + upstream.Addr().String()
+		})[0]
+
+		ts.Run(t, []test.TestCase{
+			{Code: 200},
+			{Code: 200},
+		}...)
+
+		// Set in past to re-create transport
+		spec.HTTPTransportCreated = time.Now().Add(-time.Minute)
+
+		// Should be called in new connection
+		// We already made 2 requests above, so 3th in same not allowed
+		ts.Run(t, test.TestCase{Code: 200})
+	})
 }

reverse_proxy.go

@@ -456,13 +456,15 @@ func (p *ReverseProxy) WrappedServeHTTP(rw http.ResponseWriter, req *http.Reques
 	p.TykAPISpec.Lock()
 
 	createTransport := p.TykAPISpec.HTTPTransport == nil
+
 	if !createTransport && config.Global.MaxConnTime != 0 {
 		createTransport = time.Since(p.TykAPISpec.HTTPTransportCreated) > time.Duration(config.Global.MaxConnTime)*time.Second
 	}
 
 	if createTransport {
 		_, timeout := p.CheckHardTimeoutEnforced(p.TykAPISpec, req)
 		p.TykAPISpec.HTTPTransport = httpTransport(timeout, rw, req, p)
+		p.TykAPISpec.HTTPTransportCreated = time.Now()
 	} else if IsWebsocket(req) { // check if it is an upgrade request to NEW WS-connection
 		// overwrite transport's ResponseWriter from previous upgrade request
 		// as it was already hijacked and now is being used for other connection