Enhance gRPC errors #1608
Merged
Enhance gRPC errors #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoorm
reviewed
Apr 23, 2018
main.go
Outdated
| @@ -190,7 +190,11 @@ func setupGlobals() { | |||
| } | |||
|
|
|||
| if config.Global.CoProcessOptions.EnableCoProcess { | |||
| CoProcessInit() | |||
| if err := CoProcessInit(); err != nil { | |||
| log.WithFields(logrus.Fields{ | |||
There was a problem hiding this comment.
Can just use log.WithField("prefix", "coprocess").Error(err)
matiasinsaurralde
force-pushed
the
grpc-error
branch
from
ddb8496
to
f9aa340
Compare
asoorm
approved these changes
Apr 23, 2018
|
This is a very small change, to test this, set this into your "coprocess_options": {
"enable_coprocess": true,
"coprocess_grpc_server": ""
},Without the patch you should see the recurring dialer errors. |
matiasinsaurralde
force-pushed
the
grpc-error
branch
from
f9aa340
to
71fddbf
Compare
|
Just fixed conflicts on this PR |
matiasinsaurralde
force-pushed
the
grpc-error
branch
from
c0d51fb
to
46533c4
Compare
matiasinsaurralde
force-pushed
the
grpc-error
branch
from
46533c4
to
f269457
Compare
buger
pushed a commit
that referenced
this pull request
May 30, 2018
* main: display CP init errors * coprocess: check for empty gRPC URLs before calling the dialer * coprocess: fix dummy driver * coprocess: fix config access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement for #991
The dialer already does an URL check (parsing) but this is a simpler thing to check during init