Fix Python memory issues #1886
Merged
Fix Python memory issues #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Python refcount macros. Modified the C.free calls to avoid any GC issues. Python_DispatchHook uses memcpy to avoid accessing the internal buffer of the resulting PyObject.
|
Tests are ok now! |
|
@matiasinsaurralde I see a TODO statement in comments, are you going to do it in terms of this PR? |
matiasinsaurralde
added a commit
to matiasinsaurralde/tyk
that referenced
this pull request
Sep 15, 2018
buger
pushed a commit
that referenced
this pull request
Sep 17, 2018
buger
pushed a commit
that referenced
this pull request
Oct 2, 2018
* coprocess: fix Python memory issues Added Python refcount macros. Modified the C.free calls to avoid any GC issues. Python_DispatchHook uses memcpy to avoid accessing the internal buffer of the resulting PyObject. * coprocess: modify Lua code to match dispatcher arguments * coprocess: add error results
This was referenced Mar 1, 2020
Closed
buger
pushed a commit
that referenced
this pull request
Mar 1, 2020
…2895) Fix for #2894, similar to #1886: 1. Implemented bindings for `Py_IncRef`, `Py_DecRef` and `PyTuple_ClearFreeList` (could be potentially used). 2. Corrected `free` call in `PyBytesFromString`. 3. Added refcount handlers in `coprocess_python.go`. With this patch, GC object count looks better over time (using the middleware attached in #2894): ``` myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 ``` Under some scenarios, additional tweaks might be required (either on the plugin side or Tyk Python code side) to run the GC collection more often, etc.
tykbot bot
pushed a commit
that referenced
this pull request
Mar 1, 2020
…2895) Fix for #2894, similar to #1886: 1. Implemented bindings for `Py_IncRef`, `Py_DecRef` and `PyTuple_ClearFreeList` (could be potentially used). 2. Corrected `free` call in `PyBytesFromString`. 3. Added refcount handlers in `coprocess_python.go`. With this patch, GC object count looks better over time (using the middleware attached in #2894): ``` myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 ``` Under some scenarios, additional tweaks might be required (either on the plugin side or Tyk Python code side) to run the GC collection more often, etc. (cherry picked from commit 0f8d881)
tykbot bot
pushed a commit
that referenced
this pull request
Mar 1, 2020
…2895) Fix for #2894, similar to #1886: 1. Implemented bindings for `Py_IncRef`, `Py_DecRef` and `PyTuple_ClearFreeList` (could be potentially used). 2. Corrected `free` call in `PyBytesFromString`. 3. Added refcount handlers in `coprocess_python.go`. With this patch, GC object count looks better over time (using the middleware attached in #2894): ``` myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 myhook called 29509 ``` Under some scenarios, additional tweaks might be required (either on the plugin side or Tyk Python code side) to run the GC collection more often, etc. (cherry picked from commit 0f8d881)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1228.
Added Python refcount macros. Modified the C.free calls to avoid any GC issues.
Python_DispatchHook uses memcpy to avoid accessing the internal buffer of the resulting PyObject.