Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic auth caching #2239

Merged
merged 1 commit into from
Apr 27, 2019
Merged

Fix basic auth caching #2239

merged 1 commit into from
Apr 27, 2019

Conversation

buger
Copy link
Member

@buger buger commented Apr 27, 2019

Basic auth cache was initialized for every API on every API reload.
go-cache by itself consume quite lot of resources, when started in such amounts.

Fix #2238

Basic auth cache was initialized for every API on every API reload.
go-cache by itself consume quite lot of resources, when started in such amounts.

Fix #2238
@buger buger requested a review from asoorm April 27, 2019 15:01
@buger
Copy link
Member Author

buger commented Apr 27, 2019

@asoorm ^

@buger buger merged commit 08dfc0a into master Apr 27, 2019
@buger buger deleted the fix/2238-fix-basic-auth-cache branch April 27, 2019 15:02
buger added a commit that referenced this pull request Apr 27, 2019
Basic auth cache was initialized for every API on every API reload.
go-cache by itself consume quite lot of resources, when started in such amounts.

Fix #2238
buger added a commit that referenced this pull request May 4, 2019
Basic auth cache was initialized for every API on every API reload.
go-cache by itself consume quite lot of resources, when started in such amounts.

Fix #2238
@asoorm asoorm restored the fix/2238-fix-basic-auth-cache branch June 6, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leak in basic auth middleware
1 participant