Feature/field restrictions #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furkansenharputlu
force-pushed
the
feature/field-restrictions
branch
4 times, most recently
from
f53f9c1
to
c1d760c
Compare
furkansenharputlu
changed the title
furkansenharputlu
force-pushed
the
feature/field-restrictions
branch
2 times, most recently
from
ddfc0df
to
0a9ec86
Compare
furkansenharputlu
force-pushed
the
feature/field-restrictions
branch
from
dc54397
to
010c3ae
Compare
furkansenharputlu
force-pushed
the
feature/field-restrictions
branch
from
010c3ae
to
837c46f
Compare
devsergiy
reviewed
May 11, 2020
gateway/api_definition.go
Outdated
| @@ -17,6 +17,8 @@ import ( | |||
| "text/template" | |||
| "time" | |||
|
|
|||
| "github.com/jensneuse/graphql-go-tools/pkg/graphql" | |||
There was a problem hiding this comment.
could we group imports?
like
import (
std_imports
third party
tyk
)
devsergiy
reviewed
May 11, 2020
| @@ -403,6 +403,20 @@ func (t BaseMiddleware) ApplyPolicies(session *user.SessionState) error { | |||
| } | |||
| } | |||
|
|
|||
| for _, t := range v.RestrictedTypes { | |||
There was a problem hiding this comment.
do we support partitioning of restricted types?
There was a problem hiding this comment.
I know it is unrelated to this PR but could we make iteration variables names more meaningful?
like v -> accessRight and k -> apiID
There was a problem hiding this comment.
You are right, it is very unclear but better to make it in another PR as it will change a lot of unrelated lines
devsergiy
reviewed
May 11, 2020
gateway/mw_granular_access.go
Outdated
|
|
||
| return nil, http.StatusOK | ||
|
|
||
| } else { |
There was a problem hiding this comment.
else branch is not required here as you already have returns in if
devsergiy
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3017