[TT-162] Fix JSVM session metadata usage #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add simple test for this? |
matiasinsaurralde
changed the title
matiasinsaurralde
force-pushed
the
virtual-endpoint-session-metadata
branch
from
f50540a
to
5583dcd
Compare
|
Added tests and rebased the changes 👍 |
matiasinsaurralde
force-pushed
the
virtual-endpoint-session-metadata
branch
2 times, most recently
from
8da590d
to
91a7619
Compare
matiasinsaurralde
force-pushed
the
virtual-endpoint-session-metadata
branch
from
91a7619
to
acf46a4
Compare
buger
approved these changes
Oct 18, 2020
|
/release to release-3-lts |
|
Working on it! Note that it can take a few minutes. |
tykbot bot
pushed a commit
that referenced
this pull request
Oct 19, 2020
* mw_virtual_endpoint: use map[string]interface{} for JSVM session metadata
* mw_virtual_endpoint: improve test helper and session metadata test coverage
(cherry picked from commit 3c1de7b)
|
@matiasinsaurralde Succesfully merged |
|
/release to release-3.1 |
|
Working on it! Note that it can take a few minutes. |
|
@matiasinsaurralde Seems like there is conflict and it require manual merge. |
matiasinsaurralde
added a commit
that referenced
this pull request
Oct 20, 2020
|
Am testing with v3.1.2 but I think this issue is partially fixed. Getting
I suspect it's because of the struct declaration on line 56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3218.
Description
When
use_sessionis enabled, theSessionMetaobject is expected to contain a content with the following structure:{"tyk_developer_id":"5f1937ad4ea4611eefb8ede6","tyk_key_request_fields":{},"tyk_user_fields":{}}Because we were previously using
map[string]string, the key request and user fields break the unmarshalling step.Using
map[string]interface{}fixes the issue.Related Issue
#3218.
How This Has Been Tested
Steps described in #3218.
Screenshots (if appropriate)
Types of changes
Checklist
fork, don't request your
master!masterbranch (left side). Also, you should startyour branch off our latest
master.go mod tidy && go mod vendorgo fmt -sgo vet