Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-10962 #6072

Merged
merged 1 commit into from Mar 1, 2024
Merged

TT-10962 #6072

merged 1 commit into from Mar 1, 2024

Conversation

kofoworola
Copy link
Contributor

@kofoworola kofoworola commented Feb 26, 2024

User description

Description

TT-10962

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

Type

bug_fix


Description

  • Disabled the EnableSingleFlight feature in both ProxyOnly and UniversalDataGraph adapters to address existing issues.

Changes walkthrough

Relevant files
Bug fix
adapter_proxy_only.go
Disable SingleFlight in ProxyOnly Adapter                               

apidef/adapter/gqlengineadapter/adapter_proxy_only.go

  • Disabled EnableSingleFlight feature by setting its value to false.
  • +1/-1     
    adapter_udg.go
    Disable SingleFlight in UniversalDataGraph Adapter             

    apidef/adapter/gqlengineadapter/adapter_udg.go

  • Disabled EnableSingleFlight feature by setting its value to false.
  • +1/-1     

    PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    API Changes

    no api changes detected

    Copy link

    PR Description updated to latest commit (3f1d1f7)

    Copy link

    PR Review

    ⏱️ Estimated effort to review [1-5]

    2, because the changes are straightforward and localized to specific configuration settings in two files. However, understanding the impact of these changes requires domain knowledge about the GraphQL engine configuration.

    🧪 Relevant tests

    No

    🔍 Possible issues

    Disabling EnableSingleFlight might lead to increased load on the backend services due to duplicate concurrent requests. This change could potentially degrade performance or lead to rate limiting issues if not properly accounted for.

    🔒 Security concerns

    No

    Code feedback:
    relevant fileapidef/adapter/gqlengineadapter/adapter_proxy_only.go
    suggestion      

    Consider adding a comment explaining the rationale behind setting EnableSingleFlight to false. This will help future maintainers understand the context and implications of this configuration. [important]

    relevant linev2Config.EnableSingleFlight(false)

    relevant fileapidef/adapter/gqlengineadapter/adapter_udg.go
    suggestion      

    Evaluate the impact of disabling EnableSingleFlight on the performance and reliability of the Universal Data Graph service. It may be beneficial to conduct load testing to ensure that this change does not adversely affect the system. [important]

    relevant lineconf.EnableSingleFlight(false)


    ✨ Review tool usage guide:

    Overview:
    The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
    When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

    /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...
    

    With a configuration file, use the following template:

    [pr_reviewer]
    some_config1=...
    some_config2=...
    
    Utilizing extra instructions

    The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.

    Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.

    Examples for extra instructions:

    [pr_reviewer] # /review #
    extra_instructions="""
    In the 'possible issues' section, emphasize the following:
    - Does the code logic cover relevant edge cases?
    - Is the code logic clear and easy to understand?
    - Is the code logic efficient?
    ...
    """
    

    Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

    How to enable\disable automation
    • When you first install PR-Agent app, the default mode for the review tool is:
    pr_commands = ["/review", ...]
    

    meaning the review tool will run automatically on every PR, with the default configuration.
    Edit this field to enable/disable the tool, or to change the used configurations

    Auto-labels

    The review tool can auto-generate two specific types of labels for a PR:

    • a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
    • a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)
    Extra sub-tools

    The review tool provides a collection of possible feedbacks about a PR.
    It is recommended to review the possible options, and choose the ones relevant for your use case.
    Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
    require_score_review, require_soc2_ticket, and more.

    Auto-approve PRs

    By invoking:

    /review auto_approve
    

    The tool will automatically approve the PR, and add a comment with the approval.

    To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following:

    [pr_reviewer]
    enable_auto_approval = true
    

    (this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository)

    You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag:

    [pr_reviewer]
    maximal_review_effort = 5
    
    More PR-Agent commands

    To invoke the PR-Agent, add a comment using one of the following commands:

    • /review: Request a review of your Pull Request.
    • /describe: Update the PR title and description based on the contents of the PR.
    • /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
    • /ask <QUESTION>: Ask a question about the PR.
    • /update_changelog: Update the changelog based on the PR's contents.
    • /add_docs 💎: Generate docstring for new components introduced in the PR.
    • /generate_labels 💎: Generate labels for the PR based on the PR's contents.
    • /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

    See the tools guide for more details.
    To list the possible configuration parameters, add a /config comment.

    See the review usage page for a comprehensive guide on using this tool.

    Copy link

    github-actions bot commented Feb 26, 2024

    PR Code Suggestions

    Suggestions                                                                                                                                                     
    performance
    Evaluate the impact of disabling SingleFlight mode on performance and backend load.

    Consider evaluating the impact of disabling SingleFlight mode by setting
    EnableSingleFlight(false). This change could lead to increased backend load due to
    duplicated queries. If the intention is to improve performance by allowing concurrent
    identical requests, ensure this aligns with your application's scalability and performance
    goals.

    apidef/adapter/gqlengineadapter/adapter_proxy_only.go [57]

    -v2Config.EnableSingleFlight(false)
    +v2Config.EnableSingleFlight(true) // or false, based on performance evaluation
     
    Reassess the decision to disable SingleFlight mode for consistency with performance objectives.

    Similar to the previous suggestion, carefully consider the implications of disabling
    SingleFlight with EnableSingleFlight(false) in this configuration as well. It's crucial to
    assess whether this change aligns with the performance and scalability objectives of your
    GraphQL service, especially in production environments.

    apidef/adapter/gqlengineadapter/adapter_udg.go [35]

    -conf.EnableSingleFlight(false)
    +conf.EnableSingleFlight(true) // or false, after careful consideration
     

    ✨ Improve tool usage guide:

    Overview:
    The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
    When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:

    /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...
    

    With a configuration file, use the following template:

    [pr_code_suggestions]
    some_config1=...
    some_config2=...
    
    Enabling\disabling automation

    When you first install the app, the default mode for the improve tool is:

    pr_commands = ["/improve --pr_code_suggestions.summarize=true", ...]
    

    meaning the improve tool will run automatically on every PR, with summarization enabled. Delete this line to disable the tool from running automatically.

    Utilizing extra instructions

    Extra instructions are very important for the improve tool, since they enable to guide the model to suggestions that are more relevant to the specific needs of the project.

    Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify relevant aspects that you want the model to focus on.

    Examples for extra instructions:

    [pr_code_suggestions] # /improve #
    extra_instructions="""
    Emphasize the following aspects:
    - Does the code logic cover relevant edge cases?
    - Is the code logic clear and easy to understand?
    - Is the code logic efficient?
    ...
    """
    

    Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

    A note on code suggestions quality
    • While the current AI for code is getting better and better (GPT-4), it's not flawless. Not all the suggestions will be perfect, and a user should not accept all of them automatically.
    • Suggestions are not meant to be simplistic. Instead, they aim to give deep feedback and raise questions, ideas and thoughts to the user, who can then use his judgment, experience, and understanding of the code base.
    • Recommended to use the 'extra_instructions' field to guide the model to suggestions that are more relevant to the specific needs of the project, or use the custom suggestions 💎 tool
    • With large PRs, best quality will be obtained by using 'improve --extended' mode.
    More PR-Agent commands

    To invoke the PR-Agent, add a comment using one of the following commands:

    • /review: Request a review of your Pull Request.
    • /describe: Update the PR title and description based on the contents of the PR.
    • /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
    • /ask <QUESTION>: Ask a question about the PR.
    • /update_changelog: Update the changelog based on the PR's contents.
    • /add_docs 💎: Generate docstring for new components introduced in the PR.
    • /generate_labels 💎: Generate labels for the PR based on the PR's contents.
    • /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

    See the tools guide for more details.
    To list the possible configuration parameters, add a /config comment.

    See the improve usage page for a more comprehensive guide on using this tool.

    @buger
    Copy link
    Member

    buger commented Feb 26, 2024

    API tests result - postgres15-sha256 env: success
    Branch used: refs/heads/master
    Commit:
    Triggered by: schedule (@alephnull)
    Execution page

    @buger
    Copy link
    Member

    buger commented Feb 26, 2024

    API tests result - mongo44-sha256 env: success
    Branch used: refs/heads/master
    Commit:
    Triggered by: schedule (@alephnull)
    Execution page

    Copy link

    💥 CI tests failed 🙈

    git-state

    all ok

    Please look at the run or in the Checks tab.

    @kofoworola kofoworola enabled auto-merge (squash) March 1, 2024 08:32
    Copy link

    sonarcloud bot commented Mar 1, 2024

    @kofoworola kofoworola merged commit 9ed401d into master Mar 1, 2024
    31 checks passed
    @kofoworola kofoworola deleted the fix/10962/existing-fix branch March 1, 2024 08:56
    @buger
    Copy link
    Member

    buger commented Mar 1, 2024

    API tests result - postgres15-murmur64 env: success
    Branch used: refs/heads/master
    Commit:
    Triggered by: schedule (@alephnull)
    Execution page

    @buger
    Copy link
    Member

    buger commented Mar 1, 2024

    API tests result - mongo44-murmur64 env: success
    Branch used: refs/heads/master
    Commit:
    Triggered by: schedule (@alephnull)
    Execution page

    @kofoworola
    Copy link
    Contributor Author

    /release to release-5-lts

    Copy link

    tykbot bot commented Mar 4, 2024

    Working on it! Note that it can take a few minutes.

    tykbot bot pushed a commit that referenced this pull request Mar 4, 2024
    <!-- Provide a general summary of your changes in the Title above -->
    
    [TT-10962](https://tyktech.atlassian.net/browse/TT-10962)
    
    <!-- Describe your changes in detail -->
    
    <!-- This project only accepts pull requests related to open issues. -->
    <!-- If suggesting a new feature or change, please discuss it in an
    issue first. -->
    <!-- If fixing a bug, there should be an issue describing it with steps
    to reproduce. -->
    <!-- OSS: Please link to the issue here. Tyk: please create/link the
    JIRA ticket. -->
    
    <!-- Why is this change required? What problem does it solve? -->
    
    <!-- Please describe in detail how you tested your changes -->
    <!-- Include details of your testing environment, and the tests -->
    <!-- you ran to see how your change affects other areas of the code,
    etc. -->
    <!-- This information is helpful for reviewers and QA. -->
    
    <!-- What types of changes does your code introduce? Put an `x` in all
    the boxes that apply: -->
    
    - [ ] Bug fix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing
    functionality to change)
    - [ ] Refactoring or add test (improvements in base code or adds test
    coverage to functionality)
    
    <!-- Go over all the following points, and put an `x` in all the boxes
    that apply -->
    <!-- If there are no documentation updates required, mark the item as
    checked. -->
    <!-- Raise up any additional concerns not covered by the checklist. -->
    
    - [ ] I ensured that the documentation is up to date
    - [ ] I explained why this PR updates go.mod in detail with reasoning
    why it's required
    - [ ] I would like a code coverage CI quality gate exception and have
    explained why
    
    [TT-10962]:
    https://tyktech.atlassian.net/browse/TT-10962?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
    
    ___
    
    bug_fix
    
    ___
    
    - Disabled the `EnableSingleFlight` feature in both `ProxyOnly` and
    `UniversalDataGraph` adapters to address existing issues.
    
    ___
    
    <table><thead><tr><th></th><th align="left">Relevant
    files</th></tr></thead><tbody><tr><td><strong>Bug
    fix</strong></td><td><table>
    <tr>
      <td>
        <details>
    <summary><strong>adapter_proxy_only.go</strong><dd><code>Disable
    SingleFlight in ProxyOnly Adapter</code>&nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; </dd></summary>
    <hr>
    
    apidef/adapter/gqlengineadapter/adapter_proxy_only.go
    <li>Disabled <code>EnableSingleFlight</code> feature by setting its
    value to <code>false</code>.<br>
    
    </details>
    
      </td>
    <td><a
    href="https://pull/6072/files#diff-c3d2491b83997adf408861dc51e396c95e2baabba8286309f5c344cfcee7d78b">+1/-1</a>&nbsp;
    &nbsp; &nbsp; </td>
    </tr>
    
    <tr>
      <td>
        <details>
    <summary><strong>adapter_udg.go</strong><dd><code>Disable SingleFlight
    in UniversalDataGraph Adapter</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; </dd></summary>
    <hr>
    
    apidef/adapter/gqlengineadapter/adapter_udg.go
    <li>Disabled <code>EnableSingleFlight</code> feature by setting its
    value to <code>false</code>.<br>
    
    </details>
    
      </td>
    <td><a
    href="https://pull/6072/files#diff-f01b6f97ed0e7bbe78b66c8d0c5e34fbabf49683a4a0784f7b25ebaabe97c03b">+1/-1</a>&nbsp;
    &nbsp; &nbsp; </td>
    </tr>
    </table></td></tr></tr></tbody></table>
    
    ___
    
    > ✨ **PR-Agent usage**:
    >Comment `/help` on the PR to get a list of all available PR-Agent tools
    and their descriptions
    
    Co-authored-by: Shakira Salazar <69164527+rhianeKobar@users.noreply.github.com>
    (cherry picked from commit 9ed401d)
    Copy link

    tykbot bot commented Mar 4, 2024

    @kofoworola Succesfully merged PR

    @kofoworola
    Copy link
    Contributor Author

    /release to release-5.0.12

    Copy link

    tykbot bot commented Mar 4, 2024

    @kofoworola Release branch not found

    @kofoworola
    Copy link
    Contributor Author

    /release to release-5.0

    Copy link

    tykbot bot commented Mar 4, 2024

    Working on it! Note that it can take a few minutes.

    tykbot bot pushed a commit that referenced this pull request Mar 4, 2024
    <!-- Provide a general summary of your changes in the Title above -->
    
    [TT-10962](https://tyktech.atlassian.net/browse/TT-10962)
    
    <!-- Describe your changes in detail -->
    
    <!-- This project only accepts pull requests related to open issues. -->
    <!-- If suggesting a new feature or change, please discuss it in an
    issue first. -->
    <!-- If fixing a bug, there should be an issue describing it with steps
    to reproduce. -->
    <!-- OSS: Please link to the issue here. Tyk: please create/link the
    JIRA ticket. -->
    
    <!-- Why is this change required? What problem does it solve? -->
    
    <!-- Please describe in detail how you tested your changes -->
    <!-- Include details of your testing environment, and the tests -->
    <!-- you ran to see how your change affects other areas of the code,
    etc. -->
    <!-- This information is helpful for reviewers and QA. -->
    
    <!-- What types of changes does your code introduce? Put an `x` in all
    the boxes that apply: -->
    
    - [ ] Bug fix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing
    functionality to change)
    - [ ] Refactoring or add test (improvements in base code or adds test
    coverage to functionality)
    
    <!-- Go over all the following points, and put an `x` in all the boxes
    that apply -->
    <!-- If there are no documentation updates required, mark the item as
    checked. -->
    <!-- Raise up any additional concerns not covered by the checklist. -->
    
    - [ ] I ensured that the documentation is up to date
    - [ ] I explained why this PR updates go.mod in detail with reasoning
    why it's required
    - [ ] I would like a code coverage CI quality gate exception and have
    explained why
    
    [TT-10962]:
    https://tyktech.atlassian.net/browse/TT-10962?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
    
    ___
    
    bug_fix
    
    ___
    
    - Disabled the `EnableSingleFlight` feature in both `ProxyOnly` and
    `UniversalDataGraph` adapters to address existing issues.
    
    ___
    
    <table><thead><tr><th></th><th align="left">Relevant
    files</th></tr></thead><tbody><tr><td><strong>Bug
    fix</strong></td><td><table>
    <tr>
      <td>
        <details>
    <summary><strong>adapter_proxy_only.go</strong><dd><code>Disable
    SingleFlight in ProxyOnly Adapter</code>&nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; </dd></summary>
    <hr>
    
    apidef/adapter/gqlengineadapter/adapter_proxy_only.go
    <li>Disabled <code>EnableSingleFlight</code> feature by setting its
    value to <code>false</code>.<br>
    
    </details>
    
      </td>
    <td><a
    href="https://pull/6072/files#diff-c3d2491b83997adf408861dc51e396c95e2baabba8286309f5c344cfcee7d78b">+1/-1</a>&nbsp;
    &nbsp; &nbsp; </td>
    </tr>
    
    <tr>
      <td>
        <details>
    <summary><strong>adapter_udg.go</strong><dd><code>Disable SingleFlight
    in UniversalDataGraph Adapter</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; </dd></summary>
    <hr>
    
    apidef/adapter/gqlengineadapter/adapter_udg.go
    <li>Disabled <code>EnableSingleFlight</code> feature by setting its
    value to <code>false</code>.<br>
    
    </details>
    
      </td>
    <td><a
    href="https://pull/6072/files#diff-f01b6f97ed0e7bbe78b66c8d0c5e34fbabf49683a4a0784f7b25ebaabe97c03b">+1/-1</a>&nbsp;
    &nbsp; &nbsp; </td>
    </tr>
    </table></td></tr></tr></tbody></table>
    
    ___
    
    > ✨ **PR-Agent usage**:
    >Comment `/help` on the PR to get a list of all available PR-Agent tools
    and their descriptions
    
    Co-authored-by: Shakira Salazar <69164527+rhianeKobar@users.noreply.github.com>
    (cherry picked from commit 9ed401d)
    Copy link

    tykbot bot commented Mar 4, 2024

    @kofoworola Succesfully merged PR

    @kofoworola
    Copy link
    Contributor Author

    /release to release-5.3

    Copy link

    tykbot bot commented Mar 4, 2024

    Working on it! Note that it can take a few minutes.

    tykbot bot pushed a commit that referenced this pull request Mar 4, 2024
    ## **User description**
    <!-- Provide a general summary of your changes in the Title above -->
    
    ## Description
    [TT-10962](https://tyktech.atlassian.net/browse/TT-10962)
    
    <!-- Describe your changes in detail -->
    
    ## Related Issue
    
    <!-- This project only accepts pull requests related to open issues. -->
    <!-- If suggesting a new feature or change, please discuss it in an
    issue first. -->
    <!-- If fixing a bug, there should be an issue describing it with steps
    to reproduce. -->
    <!-- OSS: Please link to the issue here. Tyk: please create/link the
    JIRA ticket. -->
    
    ## Motivation and Context
    
    <!-- Why is this change required? What problem does it solve? -->
    
    ## How This Has Been Tested
    
    <!-- Please describe in detail how you tested your changes -->
    <!-- Include details of your testing environment, and the tests -->
    <!-- you ran to see how your change affects other areas of the code,
    etc. -->
    <!-- This information is helpful for reviewers and QA. -->
    
    ## Screenshots (if appropriate)
    
    ## Types of changes
    
    <!-- What types of changes does your code introduce? Put an `x` in all
    the boxes that apply: -->
    
    - [ ] Bug fix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing
    functionality to change)
    - [ ] Refactoring or add test (improvements in base code or adds test
    coverage to functionality)
    
    ## Checklist
    
    <!-- Go over all the following points, and put an `x` in all the boxes
    that apply -->
    <!-- If there are no documentation updates required, mark the item as
    checked. -->
    <!-- Raise up any additional concerns not covered by the checklist. -->
    
    - [ ] I ensured that the documentation is up to date
    - [ ] I explained why this PR updates go.mod in detail with reasoning
    why it's required
    - [ ] I would like a code coverage CI quality gate exception and have
    explained why
    
    
    [TT-10962]:
    https://tyktech.atlassian.net/browse/TT-10962?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
    
    
    ___
    
    ## **Type**
    bug_fix
    
    
    ___
    
    ## **Description**
    - Disabled the `EnableSingleFlight` feature in both `ProxyOnly` and
    `UniversalDataGraph` adapters to address existing issues.
    
    
    ___
    
    
    
    ## **Changes walkthrough**
    <table><thead><tr><th></th><th align="left">Relevant
    files</th></tr></thead><tbody><tr><td><strong>Bug
    fix</strong></td><td><table>
    <tr>
      <td>
        <details>
    <summary><strong>adapter_proxy_only.go</strong><dd><code>Disable
    SingleFlight in ProxyOnly Adapter</code>&nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; </dd></summary>
    <hr>
    
    apidef/adapter/gqlengineadapter/adapter_proxy_only.go
    <li>Disabled <code>EnableSingleFlight</code> feature by setting its
    value to <code>false</code>.<br>
    
    
    </details>
        
    
      </td>
    <td><a
    href="https://pull/6072/files#diff-c3d2491b83997adf408861dc51e396c95e2baabba8286309f5c344cfcee7d78b">+1/-1</a>&nbsp;
    &nbsp; &nbsp; </td>
    </tr>                    
    
    <tr>
      <td>
        <details>
    <summary><strong>adapter_udg.go</strong><dd><code>Disable SingleFlight
    in UniversalDataGraph Adapter</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; </dd></summary>
    <hr>
    
    apidef/adapter/gqlengineadapter/adapter_udg.go
    <li>Disabled <code>EnableSingleFlight</code> feature by setting its
    value to <code>false</code>.<br>
    
    
    </details>
        
    
      </td>
    <td><a
    href="https://pull/6072/files#diff-f01b6f97ed0e7bbe78b66c8d0c5e34fbabf49683a4a0784f7b25ebaabe97c03b">+1/-1</a>&nbsp;
    &nbsp; &nbsp; </td>
    </tr>                    
    </table></td></tr></tr></tbody></table>
    
    ___
    
    > ✨ **PR-Agent usage**:
    >Comment `/help` on the PR to get a list of all available PR-Agent tools
    and their descriptions
    
    Co-authored-by: Shakira Salazar <69164527+rhianeKobar@users.noreply.github.com>
    (cherry picked from commit 9ed401d)
    buger added a commit that referenced this pull request Mar 4, 2024
    TT-10962 (#6072)
    
    ## **User description**
    <!-- Provide a general summary of your changes in the Title above -->
    
    ## Description
    [TT-10962](https://tyktech.atlassian.net/browse/TT-10962)
    
    <!-- Describe your changes in detail -->
    
    ## Related Issue
    
    <!-- This project only accepts pull requests related to open issues. -->
    <!-- If suggesting a new feature or change, please discuss it in an
    issue first. -->
    <!-- If fixing a bug, there should be an issue describing it with steps
    to reproduce. -->
    <!-- OSS: Please link to the issue here. Tyk: please create/link the
    JIRA ticket. -->
    
    ## Motivation and Context
    
    <!-- Why is this change required? What problem does it solve? -->
    
    ## How This Has Been Tested
    
    <!-- Please describe in detail how you tested your changes -->
    <!-- Include details of your testing environment, and the tests -->
    <!-- you ran to see how your change affects other areas of the code,
    etc. -->
    <!-- This information is helpful for reviewers and QA. -->
    
    ## Screenshots (if appropriate)
    
    ## Types of changes
    
    <!-- What types of changes does your code introduce? Put an `x` in all
    the boxes that apply: -->
    
    - [ ] Bug fix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing
    functionality to change)
    - [ ] Refactoring or add test (improvements in base code or adds test
    coverage to functionality)
    
    ## Checklist
    
    <!-- Go over all the following points, and put an `x` in all the boxes
    that apply -->
    <!-- If there are no documentation updates required, mark the item as
    checked. -->
    <!-- Raise up any additional concerns not covered by the checklist. -->
    
    - [ ] I ensured that the documentation is up to date
    - [ ] I explained why this PR updates go.mod in detail with reasoning
    why it's required
    - [ ] I would like a code coverage CI quality gate exception and have
    explained why
    
    
    [TT-10962]:
    https://tyktech.atlassian.net/browse/TT-10962?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
    
    
    ___
    
    ## **Type**
    bug_fix
    
    
    ___
    
    ## **Description**
    - Disabled the `EnableSingleFlight` feature in both `ProxyOnly` and
    `UniversalDataGraph` adapters to address existing issues.
    
    
    ___
    
    
    
    ## **Changes walkthrough**
    <table><thead><tr><th></th><th align="left">Relevant
    files</th></tr></thead><tbody><tr><td><strong>Bug
    fix</strong></td><td><table>
    <tr>
      <td>
        <details>
    <summary><strong>adapter_proxy_only.go</strong><dd><code>Disable
    SingleFlight in ProxyOnly Adapter</code>&nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; </dd></summary>
    <hr>
    
    apidef/adapter/gqlengineadapter/adapter_proxy_only.go
    <li>Disabled <code>EnableSingleFlight</code> feature by setting its
    value to <code>false</code>.<br>
    
    
    </details>
        
    
      </td>
    <td><a
    href="https://pull/6072/files#diff-c3d2491b83997adf408861dc51e396c95e2baabba8286309f5c344cfcee7d78b">+1/-1</a>&nbsp;
    &nbsp; &nbsp; </td>
    </tr>                    
    
    <tr>
      <td>
        <details>
    <summary><strong>adapter_udg.go</strong><dd><code>Disable SingleFlight
    in UniversalDataGraph Adapter</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; </dd></summary>
    <hr>
    
    apidef/adapter/gqlengineadapter/adapter_udg.go
    <li>Disabled <code>EnableSingleFlight</code> feature by setting its
    value to <code>false</code>.<br>
    
    
    </details>
        
    
      </td>
    <td><a
    href="https://pull/6072/files#diff-f01b6f97ed0e7bbe78b66c8d0c5e34fbabf49683a4a0784f7b25ebaabe97c03b">+1/-1</a>&nbsp;
    &nbsp; &nbsp; </td>
    </tr>                    
    </table></td></tr></tr></tbody></table>
    
    ___
    
    > ✨ **PR-Agent usage**:
    >Comment `/help` on the PR to get a list of all available PR-Agent tools
    and their descriptions
    
    Co-authored-by: Shakira Salazar <69164527+rhianeKobar@users.noreply.github.com>
    Copy link

    tykbot bot commented Mar 4, 2024

    Still working...

    Copy link

    tykbot bot commented Mar 4, 2024

    @kofoworola Succesfully merged PR

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    4 participants