Merging to release-5.0: TT-10962 (#6072) #6091
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Provide a general summary of your changes in the Title above --> [TT-10962](https://tyktech.atlassian.net/browse/TT-10962) <!-- Describe your changes in detail --> <!-- This project only accepts pull requests related to open issues. --> <!-- If suggesting a new feature or change, please discuss it in an issue first. --> <!-- If fixing a bug, there should be an issue describing it with steps to reproduce. --> <!-- OSS: Please link to the issue here. Tyk: please create/link the JIRA ticket. --> <!-- Why is this change required? What problem does it solve? --> <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why [TT-10962]: https://tyktech.atlassian.net/browse/TT-10962?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ ___ bug_fix ___ - Disabled the `EnableSingleFlight` feature in both `ProxyOnly` and `UniversalDataGraph` adapters to address existing issues. ___ <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>adapter_proxy_only.go</strong><dd><code>Disable SingleFlight in ProxyOnly Adapter</code> </dd></summary> <hr> apidef/adapter/gqlengineadapter/adapter_proxy_only.go <li>Disabled <code>EnableSingleFlight</code> feature by setting its value to <code>false</code>.<br> </details> </td> <td><a href="https://pull/6072/files#diff-c3d2491b83997adf408861dc51e396c95e2baabba8286309f5c344cfcee7d78b">+1/-1</a> </td> </tr> <tr> <td> <details> <summary><strong>adapter_udg.go</strong><dd><code>Disable SingleFlight in UniversalDataGraph Adapter</code> </dd></summary> <hr> apidef/adapter/gqlengineadapter/adapter_udg.go <li>Disabled <code>EnableSingleFlight</code> feature by setting its value to <code>false</code>.<br> </details> </td> <td><a href="https://pull/6072/files#diff-f01b6f97ed0e7bbe78b66c8d0c5e34fbabf49683a4a0784f7b25ebaabe97c03b">+1/-1</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > ✨ **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions Co-authored-by: Shakira Salazar <69164527+rhianeKobar@users.noreply.github.com> (cherry picked from commit 9ed401d)
💥 CI tests failed 🙈git-stateall okPlease look at the run or in the Checks tab. |
|
API tests result: failure 🚫 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TT-10962 (#6072)
User description
Description
TT-10962
Related Issue
Motivation and Context
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
functionality to change)
coverage to functionality)
Checklist
why it's required
explained why
Type
bug_fix
Description
EnableSingleFlightfeature in bothProxyOnlyandUniversalDataGraphadapters to address existing issues.Changes walkthrough
adapter_proxy_only.go
Disable SingleFlight in ProxyOnly Adapterapidef/adapter/gqlengineadapter/adapter_proxy_only.go
EnableSingleFlightfeature by setting its value tofalse.adapter_udg.go
Disable SingleFlight in UniversalDataGraph Adapterapidef/adapter/gqlengineadapter/adapter_udg.go
EnableSingleFlightfeature by setting its value tofalse.Co-authored-by: Shakira Salazar 69164527+rhianeKobar@users.noreply.github.com