Fix compiler warning in SerialManagerBase.cpp #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I compile the first example (AudioPassThru) I get this warning:
/Users/jamescook/Documents/Arduino/libraries/Tympan_Library/src/SerialManagerBase.cpp: In member function 'virtual void SerialManagerBase::respondToByte(char)':
/Users/jamescook/Documents/Arduino/libraries/Tympan_Library/src/SerialManagerBase.cpp:56:46: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
stream_length = *((int*)(stream_data));
The warning comes from the cast of byte stream_data[SIZE] to int*. See
https://www.ibm.com/docs/en/ztpf/1.1.0.14?topic=warnings-type-pun-problems
Since the code appears to be correct, use reinterpret_cast<> and a
separate local variable to avoid the warning.
|
@chipaudette please take a look. (And let me know if I'm doing the code review workflow wrong -- this is my first pull request!) |
|
Hello @jamescookmd. Thanks for creating this pull request and bringing the issue to our attention. I found myself needing to extend the datastream capabilities so I added a way to set a callback when a multi-byte data stream message is received. I addressed the de-referenced type pun warning by using memcpy to avoid memory misalignment errors. I hope that you find it satisfactory. If not, please raise a concern at the new pull request. Because this new pull request covers this issue as well, I am closing it. Thanks for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I compile the first example (AudioPassThru) I get this warning:
/Users/jamescook/Documents/Arduino/libraries/Tympan_Library/src/SerialManagerBase.cpp: In member function 'virtual void SerialManagerBase::respondToByte(char)':
/Users/jamescook/Documents/Arduino/libraries/Tympan_Library/src/SerialManagerBase.cpp:56:46: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
stream_length = ((int)(stream_data));
The warning comes from the cast of byte stream_data[SIZE] to int*. See
https://www.ibm.com/docs/en/ztpf/1.1.0.14?topic=warnings-type-pun-problems
Since the code appears to be correct, use reinterpret_cast<> and a
separate local variable to avoid the warning.
This is my first github pull request, please let me know if I'm doing something wrong. :-)