-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Feature_Add_Callback... to Main #65
Merge Feature_Add_Callback... to Main #65
Conversation
Here is a good article on misalignment and type punning |
69ddd94
to
1a38bcc
Compare
Sorry for all the shenanigans! I accidentally pushed to main instead. I'll reopen this pull request when everything is straightened out.. |
Added checks to ensure buffer is not overrun and that the length is sent as 4-bytes. The latter was tested with a message that erroneously has a 3-byte length: |
@kxm-creare What other applications use this data stream? Should I test a hearing aid script to ensure I did not bugger up 4-character messages? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @chipaudette when we switched to BLE, I believe we disabled the use of predefined pages (GHA, AFC, DSL). Do you recall this? I don't remember if this was something that @hgeithner-creare tested or not.
@kxm-creare, Hmm...I don't remember if we disabled the predefined pages or not. I'm pretty sure that we didn't expose them for any of our ASA participants. Yes, maybe the reason is because we disabled them! I agree that I don't think that Haley tested any of that functionality. So, whether or not they are disabled, they are not tested. |
Added callback for multibyte serial messages. Tested using Realterm to send:
See attached script that modified an SD Card Writer example to register a callback function
DataStream_example.zip
Here is background info copied from SerialManagerBase.h