fix: Error caused by converting hardBreak nodes
#229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Nice find!! I think programmability wise, it would definitely be easier if we could just represent it with |
YousefED
requested changes
Jun 12, 2023
YousefED
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you press Shift+Tab in a block, it creates a new line in the same block which TIpTap/ProseMirror store as a
hardBreaknode. It turns out we completely forgot about these when doing inline content conversions, so this PR remedies that.This also fixes the
Empty text nodes are not allowederror that some people have been getting, mentioned in issues #184 and #216.Closes #184
Closes #216