Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump prosemirror-trailing-node to 2.0.8 #611

Merged
merged 1 commit into from Mar 5, 2024

Conversation

LoneRifle
Copy link
Contributor

@LoneRifle LoneRifle commented Mar 5, 2024

Bump prosemirror-trailing-node to 2.0.8 to pick up remirror/remirror#2245, which drops @remirror/core-helpers.
The latter package was heavy, bringing in several additional dependencies, but was only used to create
an array of unique elements, and to check for the presence of elements in arrays.

Accordingly, they have been replaced in 2.0.8 with equivalent code that relies on standard built-in objects.

This PR has been submitted through the course of work for @opengovsg

Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Mar 5, 2024 5:04pm
blocknote-website ✅ Ready (Inspect) Visit Preview Mar 5, 2024 5:04pm

Copy link

vercel bot commented Mar 5, 2024

@LoneRifle is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

@YousefED
Copy link
Collaborator

YousefED commented Mar 5, 2024

Thanks!

@LoneRifle I would love to hear more about how @opengovsg is using BlockNote. Exciting! Mind shooting a message on discord or to yousef@blocknotejs.org?

@YousefED YousefED merged commit df1c28a into TypeCellOS:main Mar 5, 2024
5 checks passed
@LoneRifle
Copy link
Contributor Author

Thanks!

@LoneRifle I would love to hear more about how @opengovsg is using BlockNote. Exciting! Mind shooting a message on discord or to yousef@blocknotejs.org?

We're not - a patch was made to prosemirror-trailing-node as we were dependent on it downstream. This PR is part of follow-up work to help other projects pick up the changes we have made.

@YousefED
Copy link
Collaborator

YousefED commented Mar 6, 2024

Thanks!
@LoneRifle I would love to hear more about how @opengovsg is using BlockNote. Exciting! Mind shooting a message on discord or to yousef@blocknotejs.org?

We're not - a patch was made to prosemirror-trailing-node as we were dependent on it downstream. This PR is part of follow-up work to help other projects pick up the changes we have made.

Got it, thanks. Very kind!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants