Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(trailing-node): remove @remirror/core-helpers #2245

Merged
merged 3 commits into from
Mar 5, 2024
Merged

refactor(trailing-node): remove @remirror/core-helpers #2245

merged 3 commits into from
Mar 5, 2024

Conversation

LoneRifle
Copy link
Contributor

@LoneRifle LoneRifle commented Mar 1, 2024

Description

Replace use of includes() and uniqueArray() with equivalent code that relies on standard built-in objects, allowing us to avoid importing the rest of @remirror/core-helpers, which prosemirror-trailing-node does not need

Background and Context

@remirror/core-helpers imports throttle-debounce, which, while licensed under MIT, is a fork of jquery-throttle-debounce, which is dual-licensed under MIT and GPL. There is significant legal ambiguity whether dependents are free to comply with just one of the licenses, or compliance with both licenses is needed, especially since the author of jquery-throttle-debounce did not explicitly state in no uncertain terms what is acceptable, and what is not.

Given that prosemirror-trailing-node does not actually need throttling or debouncing, and the helper functions needed are relatively trivial to implement (at least in the context of this particular package), and given that there are other packages outside of Remirror that depend on this package (eg, @tiptap/pm), this PR has been made to help dependents avoid this legal ambiguity

Checklist

  • I have read the contributing document.
  • My code follows the code style of this project and pnpm fix completed successfully.
  • I have updated the documentation where necessary.
  • New code is unit tested and all current tests pass when running pnpm test.

Footnote

This contribution has been made through the course of work done for @opengovsg

Copy link

changeset-bot bot commented Mar 1, 2024

🦋 Changeset detected

Latest commit: ac4f540

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
prosemirror-trailing-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LoneRifle LoneRifle changed the title refactor(trailing-node): remove @remirror/core-helpers refactor(trailing-node): remove @remirror/core-helpers Mar 1, 2024
LoneRifle and others added 3 commits March 1, 2024 03:00
Replace use of `includes()` and `uniqueArray()` with equivalent code
that relies on standard built-in objects, allowing us to avoid import
of the rest of `@remirror/core-helpers`, which we do not need
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants