Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formalized comment doesn't works in incremental #1130

Closed
smedilol opened this issue Sep 17, 2018 · 4 comments
Closed

Formalized comment doesn't works in incremental #1130

smedilol opened this issue Sep 17, 2018 · 4 comments
Assignees
@mayanje
Labels
Bug TC-Comment User Visible Visible by the end user. Useful to priorize issue
Projects
2019-01 to 2019-02 2019-03
Milestone
v1.3 Codegen refa...

Comments

@smedilol
Copy link
Contributor

Describe the bug
When you type a formalized comment `*<<< my comment *>>>' you get an error.
You need to re-synchronize the document to get rid of this error.
@smedilol smedilol added Bug User Visible Visible by the end user. Useful to priorize issue TC-Comment labels Sep 17, 2018
@smedilol smedilol added this to the Formalized comment milestone Sep 17, 2018
@smedilol
Copy link
Contributor Author

See if #1234 and #1229 fix this

@smedilol
Copy link
Contributor Author

@sarterbe can you check if the last version still procedure error with formalized comment ?

@smedilol smedilol added this to In progress in 2019-01 to 2019-02 Jan 28, 2019
@smedilol smedilol moved this from In progress to Needs review in 2019-01 to 2019-02 Feb 4, 2019
@smedilol smedilol added this to Needs review in 2019-03 Mar 4, 2019
@smedilol smedilol assigned mayanje and unassigned sarterbe Apr 8, 2019
@maxime645
Copy link
Contributor

The issue is still occuring.
When adding a new @Keyword, the first line of TypeCobol code after it shows a syntax error. It goes away when a manual save is made.
There is no error thrown when adding a simple description without the keyword @description.

mayanje added a commit that referenced this issue Apr 9, 2019
@mayanje
WI #1130 Take in account code elements with a formalized comment.
9051146
2019-01 to 2019-02 automation moved this from Needs review to Done Apr 11, 2019
2019-03 automation moved this from Needs review to Done Apr 11, 2019
@mayanje mayanje reopened this Apr 12, 2019
2019-01 to 2019-02 automation moved this from Done to In progress Apr 12, 2019
2019-03 automation moved this from Done to In progress Apr 12, 2019
@mayanje
Copy link
Contributor

mayanje commented Apr 12, 2019

This issue is reopened because in fact the flag FormalizedCommentLineEnd is not necessary

mayanje added a commit that referenced this issue Apr 12, 2019
@mayanje
WI #1130 Remove flag FormalizedCommentLineEnd
641fb14
mayanje added a commit that referenced this issue Apr 12, 2019
@mayanje
WI #1130 Remove flag FormalizedCommentLineEnd (#1353)
e6c201f
2019-01 to 2019-02 automation moved this from In progress to Done Apr 30, 2019
2019-03 automation moved this from In progress to Done Apr 30, 2019
@maxime645 maxime645 mentioned this issue May 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayanje mayanje

Labels
Bug TC-Comment User Visible Visible by the end user. Useful to priorize issue
Projects
2019-01 to 2019-02
  
Done
2019-03
  
Done
Milestone
v1.3 Codegen refacto / data size / ge...
Development

No branches or pull requests
4 participants
@sarterbe @smedilol @mayanje @maxime645