Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug for incremental mode and multi line changes. #1234

Closed
mayanje opened this issue Jan 21, 2019 · 6 comments
Closed

Bug for incremental mode and multi line changes. #1234

mayanje opened this issue Jan 21, 2019 · 6 comments
Assignees
@mayanje
Labels
Bug TypeCobol User Visible Visible by the end user. Useful to priorize issue
Milestone
v1.3 Codegen refa...

Comments

@mayanje
Copy link
Contributor

mayanje commented Jan 21, 2019

When several lines are impacted by incremental scanning and maybe by a multilscanstate, some lines are not entirely rescanned or invalidated for incremental code element reparsing
@mayanje mayanje self-assigned this Jan 21, 2019
mayanje added a commit that referenced this issue Jan 21, 2019
@mayanje
WI #1234 Modify incremental scanning algorithm + adapt and add unit t…
f8e0a67 
…ests.
mayanje added a commit that referenced this issue Jan 22, 2019
@mayanje
Merge pull request #1236 from TypeCobolTeam/1234_BugIncremental
bf81e69 
WI #1234 Modify incremental scanning algorithm + adapt and add unit t…
@mayanje mayanje mentioned this issue Jan 22, 2019
Closed
@mayanje mayanje closed this as completed Jan 28, 2019
@smedilol smedilol mentioned this issue Jan 28, 2019
Closed
@smedilol
Copy link
Contributor

smedilol commented Feb 4, 2019

Can you update the documentation about incremental:
https://github.com/TypeCobolTeam/TypeCobol/wiki/TypeCobolIncrementalPipeline

@smedilol smedilol reopened this Feb 4, 2019
@mayanje
Copy link
Contributor Author

mayanje commented Feb 4, 2019

I had a look to this documentation and I made minor changes, otherwise nothing has changed concerning the meaning of functions and the workflow. No functions has been added or removed.

@smedilol
Copy link
Contributor

smedilol commented Feb 6, 2019

The goal is to indicate the rules of incremental. Like:

  • Reset code Elements
  • When to stop the scanning of lines

@mayanje
Copy link
Contributor Author

mayanje commented Feb 6, 2019

This is another issue your are asking to describe here the underlying Incremental Algorithms used for both Incremental Scanning and Incremental Code Element parsing.

@smedilol smedilol added the User Visible Visible by the end user. Useful to priorize issue label Feb 12, 2019
@mayanje
Copy link
Contributor Author

mayanje commented Feb 12, 2019 •
edited

Ok I have updated https://github.com/TypeCobolTeam/TypeCobol/wiki/TypeCobolIncrementalPipeline
and referenced #1277

@smedilol
Copy link
Contributor

Ok, thanks.

@maxime645 maxime645 mentioned this issue May 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayanje mayanje

Labels
Bug TypeCobol User Visible Visible by the end user. Useful to priorize issue
Projects
None yet
Milestone
v1.3 Codegen refacto / data size / ge...
Development

No branches or pull requests
2 participants
@smedilol @mayanje