Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WI #2488 Migrate to .NET 6.0 #2497

Merged
merged 11 commits into from
Apr 20, 2023
Merged

WI #2488 Migrate to .NET 6.0 #2497

merged 11 commits into from
Apr 20, 2023

Conversation

fm-117
Copy link
Contributor

@fm-117 fm-117 commented Apr 13, 2023 •
edited

Fixes #2488.

What has been done ?

  • Recreated all projects from scratch using new simplified csproj model
  • Fixed path-related operations in unit tests because of new output dirs
    • Instead of a shared bin/obj, we now have separate bin/obj per project
  • Removed all AssemblyInfo.cs, now using defaults from .NET or customizations directly written in csproj
  • Updated test results because of loss of precision in double type (?)
  • Update test results because of new display name for assemblys (now without extension)
  • Removed all *.config files
    • App.config were not used
    • packages.config are now integrated into csproj thanks to <PackageReference>
  • Removed some unused test files, added one cpy file that was previously linked
  • Rewritten Performance tests with CFG or DFA using composition instead of inheritance which seems cleaner for MSTest...
  • Fixed some namespace conflicts due to the new implicit usings feature
  • Updated use of GetEncoding which now require codepage provider registration
  • Rewritten CSCup code generation prebuild as a Powershell script
    • Removed generated files from source control
  • Migrated from AppVeyor CI To GitHub Actions
    • Removed old build script
    • Added new workflow files
  • Added helper project to retrieve LanguageServerRobot and LanguageServerRobot Monitor as NuGet packages
  • Added script to prepare debug of LanguageServer

@fm-117 fm-117 requested review from smedilol and efr15 April 13, 2023 12:13
@fm-117 fm-117 self-assigned this Apr 13, 2023
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Apr 13, 2023
@fm-117 fm-117 changed the title 2488 migrate to net 60 WI #2488 Migrate to .NET 6.0 Apr 13, 2023
@fm-117 fm-117 mentioned this pull request Apr 13, 2023
Merged
@trafico-bot trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label Apr 18, 2023
@fm-117 fm-117 requested a review from smedilol April 20, 2023 12:21
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Apr 20, 2023
@fm-117
WI #2488 Update trigger branches for GitHub Workflow
0852b5a
@fm-117
Merge branch 'develop_net6.0' into 2488-migrate-to-net-60
9ca9b18 
# Conflicts:
#	TypeCobol/Compiler/CupParser/TypeCobolProgramParser.cs
#	TypeCobol/Compiler/CupParser/TypeCobolProgramSymbols.cs
@fm-117 fm-117 merged commit 18d1cb1 into develop_net6.0 Apr 20, 2023
4 of 5 checks passed
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Apr 20, 2023
@fm-117 fm-117 deleted the 2488-migrate-to-net-60 branch April 20, 2023 15:34
@trafico-bot trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label Apr 20, 2023
@fm-117 fm-117 mentioned this pull request May 2, 2023
Merged
fm-117 added a commit that referenced this pull request May 3, 2023
@fm-117
WI #2488 Migrate to .NET 6.0 (#2508)
d3e7177 
* WI #2488 Migrate to .NET 6.0 (#2497)

* WI #2488 Specify sln file in workflow

* WI #2488 Use newer API for string.Replace

* WI #2488 Use module initializer

* WI #2488 Clean workflow trigger branches

* WI #2488 Fix compilation constant for custom build configs

* WI #2488 Disable nullable checks but raise severity for future migration
@fm-117 fm-117 mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efr15 efr15 efr15 approved these changes

@smedilol smedilol Awaiting requested review from smedilol

Assignees

@fm-117 fm-117

Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fm-117 @smedilol @efr15