2221 data type with picture validator #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix tests which check picture tu use Uknkown when picture is wrong.
fm-117
requested changes
Apr 21, 2023
trafico-bot
bot
added
⚠️ Changes requested
efr15
approved these changes
Apr 24, 2023
# Conflicts: # TypeCobol/Compiler/CupParser/TypeCobolProgramParser.cs # TypeCobol/Compiler/CupParser/TypeCobolProgramSymbols.cs
trafico-bot
bot
added
🔍 Ready for Review
…peWithPictureValidator
|
I changed the target branch to develop_net6.0. This gives the opportunity to specify certain nullable variables explicitly. |
fm-117
previously approved these changes
Apr 27, 2023
efr15
previously approved these changes
Apr 27, 2023
# Conflicts: # .github/workflows/dotnet.yml # CLI/src/CLI.csproj # CLI/test/CLI.Test.csproj # CSCup/CSCup.csproj # CSCupRuntime/CSCupRuntime.csproj # Codegen/src/Codegen.csproj # Codegen/test/Codegen.Test.csproj # Common.props # TypeCobol.Analysis.Test/TypeCobol.Analysis.Test.csproj # TypeCobol.Analysis/TypeCobol.Analysis.csproj # TypeCobol.LanguageServer.Test/TypeCobol.LanguageServer.Test.csproj # TypeCobol.LanguageServer/TypeCobol.LanguageServer.csproj # TypeCobol.Test/TypeCobol.Test.csproj # TypeCobol.Transform.Test/TypeCobol.Transform.Test.csproj # TypeCobol.Transform/TypeCobol.Transform.csproj # TypeCobol/TypeCobol.csproj
fm-117
previously approved these changes
May 4, 2023
efr15
previously approved these changes
May 4, 2023
fm-117
approved these changes
May 4, 2023
efr15
approved these changes
May 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2221
Optimize DataType creation by using the result of PictureValidator.
There is no gain in incremental mode.
The gain in full parsing is low : about 5%.