Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to npm workspaces #340

Merged
merged 9 commits into from
Apr 8, 2022
Merged

Switch to npm workspaces #340

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6151eea
WIP: Transform to npm workspace, update dependencies and enable GitHu…
kaisalmen Mar 18, 2022
4138469
Move all examples to new locations
kaisalmen Apr 4, 2022
33c8b35
package.json clean-up: dependencies declared where needed
kaisalmen Apr 4, 2022
479e715
Switched client example to vite and node example only relies on types…
kaisalmen Apr 5, 2022
10b2357
All examples are working again.
kaisalmen Apr 6, 2022
0342a9c
Update README and CHANGELOG
kaisalmen Apr 6, 2022
15cdf18
Replace travis badges with github actions
kaisalmen Apr 6, 2022
dadde1b
Fix: Contain amd build in library
kaisalmen Apr 6, 2022
2c0102c
Implemented changes from first review feedback
kaisalmen Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ All notable changes to this project will be documented in this file.
* Switch to npm workspace and vite and thereby drop yarn, lerna and webpack
* Restructure project: All code is moved to packages directory
* Update and clean-up all dependencies
* Use monaco-editor in examples
* Use monaco-editor in examples instead of monaco-editor-core
* README is fully updated

## [0.18.1] - 2022-03-21
Expand Down
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ A new maintainer should be listed as [a current maintainer](#current-maintainers

### Releasing

**TODO: This is outdated and needs to be discussed.**
CGNonofr marked this conversation as resolved.
Show resolved Hide resolved

For simplicity, each release should bump the minor version.

- Publish:
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

[![Gitpod - Code Now](https://img.shields.io/badge/Gitpod-code%20now-blue.svg?longCache=true)](https://gitpod.io#https://github.com/TypeFox/monaco-languageclient)
[![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg?longCache=true)](https://github.com/TypeFox/monaco-languageclient/labels/help%20wanted)
[![Build Status](https://travis-ci.org/TypeFox/monaco-languageclient.svg?branch=master)](https://travis-ci.org/TypeFox/monaco-languageclient)
[![monaco-languageclient](https://github.com/TypeFox/monaco-languageclient/actions/workflows/actions.yml/badge.svg)](https://github.com/TypeFox/monaco-languageclient/actions/workflows/actions.yml)
[![NPM Version](https://img.shields.io/npm/v/monaco-languageclient.svg)](https://www.npmjs.com/package/monaco-languageclient)
[![NPM Download](https://img.shields.io/npm/dt/monaco-languageclient.svg)](https://www.npmjs.com/package/monaco-languageclient)

Expand All @@ -24,7 +24,7 @@

### Project Modernization

From release 0.19.0 onward the project switched to npm workspaces. We no longer require yarn, lerna and webpack. Mostly therefore we the list of `devDependencies` is substantially shorter. All code has been moved to [./packages](./packages) directory.
From release 0.19.0 onward the project switched to npm workspaces. We no longer require yarn, lerna and webpack. Mostly therefore we the list of `devDependencies` is substantially shorter. All code has been moved to [./packages](./packages) directory.
CGNonofr marked this conversation as resolved.
Show resolved Hide resolved

As before the library code is just compiled with the TypeScript compiler and the library is now packaged with npm. The need for bundling does no longer exist for the example. The compiled code is either executed by node or the web/client related code/pages are served with [vite.js](https://vitejs.dev/).

Expand Down
4 changes: 2 additions & 2 deletions packages/client/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Monaco Language Client
[![Gitpod - Code Now](https://img.shields.io/badge/Gitpod-code%20now-blue.svg?longCache=true)](https://gitpod.io#https://github.com/TypeFox/monaco-languageclient)
[![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg?longCache=true)](https://github.com/TypeFox/monaco-languageclient/labels/help%20wanted)
[![Build Status](https://travis-ci.org/TypeFox/monaco-languageclient.svg?branch=master)](https://travis-ci.org/TypeFox/monaco-languageclient)
[![monaco-languageclient](https://github.com/TypeFox/monaco-languageclient/actions/workflows/actions.yml/badge.svg)](https://github.com/TypeFox/monaco-languageclient/actions/workflows/actions.yml)
[![NPM Version](https://img.shields.io/npm/v/monaco-languageclient.svg)](https://www.npmjs.com/package/monaco-languageclient)
[![NPM Download](https://img.shields.io/npm/dt/monaco-languageclient.svg)](https://www.npmjs.com/package/monaco-languageclient)

Expand All @@ -14,4 +14,4 @@ See [here](https://github.com/TypeFox/monaco-languageclient/blob/master/README.m
For the history please see the [main repository](https://github.com/TypeFox/monaco-languageclient/blob/master/CHANGELOG.md).

## License
[MIT](https://github.com/TypeFox/monaco-languageclient/blob/master/License.txt)
[MIT](https://github.com/TypeFox/monaco-languageclient/blob/master/License.txt)