Switch to npm workspaces #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- client keeps original typescript config for now - Test vite in examples/client
…cirpt and node, no webpack needed
- Moved vite to top level - Removed substantial amount of devDependencies due to webpack removal - Fixed compile issues (browser example) - Fixed error regression in vscode-compatibility - Cleaned-up all tsconfig.json - Fix gitpod config
- Update Copyright statements - Fix vscode launch configs - Remove unneeded files
kaisalmen
requested review from
gatesn,
mofux,
BroKun,
rcjsuen,
asual,
johnwiseheart,
RomanNikitenko and
azatsarynnyy
as code owners
|
I removed the travis-ci check now. With this PR we get GitHub Actions that we can extend over time if we see the need. |
CGNonofr
reviewed
Apr 6, 2022
|
There is a lot of changes so it's hard to review, there is also some comments that are not relevant anymore I think |
My apologies. This is maily about built, tools and dependencies and not about what the code really does. Did you have time to try it out, btw? |
|
I added these two points to #315:
|
This was referenced Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #331 and substantially changes the repositories structure, build process and tooling. It does not change code apart from compiler error fixes required after TypeScript update:
This PR could be best checked with a fresh checkout. Please have a look at the updated README if the instructions are good and sufficient. Please check if the example still work as expected. I think so, but I am only involved here since a couple of weeks and may have missed something or misunderstood something.