Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ts-node for example #344

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Use ts-node for example #344

merged 2 commits into from
Apr 8, 2022

Conversation

CGNonofr
Copy link
Collaborator

@CGNonofr CGNonofr commented Apr 8, 2022

No description provided.

@CGNonofr
Copy link
Collaborator Author

CGNonofr commented Apr 8, 2022

It looks like the build script is used by the ci, but isn't it useless everywhere else?

@CGNonofr
Copy link
Collaborator Author

CGNonofr commented Apr 8, 2022

Feel free to edit this PR @kaisalmen

@kaisalmen
Copy link
Collaborator

The build step is still meaningful to see if there are any code errors (and here the CI is useful, because it detects mistakes). vite/esbuild does not compile ts files, ts-node breaks, I guess

@CGNonofr
Copy link
Collaborator Author

CGNonofr commented Apr 8, 2022

vite/esbuild does not compile ts files, ts-node breaks, I guess

I'm not sure what you mean

I removed the 2 last commits

btw: there is a noEmit option for typescript to just check without emitting javascript files

@kaisalmen
Copy link
Collaborator

there is a noEmit option

Yeah, good idea.

I'm not sure what you mean

vite/esbuild does not invoke the tsc compiler. They just remove type information and produces javascript on the fly. That's why it is so fast, but in general before going to production you should everything compiles (no type issues, etc.)

@CGNonofr
Copy link
Collaborator Author

CGNonofr commented Apr 8, 2022

vite/esbuild does not invoke the tsc compiler. They just remove type information and produces javascript on the fly. That's why it is so fast, but in general before going to production you should everything compiles (no type issues, etc.)

got it!

@kaisalmen kaisalmen merged commit 5d08fd0 into master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants