-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quotes to wrap XpathExpression should be kept as what it is after serialization #118
Comments
Could you elaborate on the serialization usecase? Do you read in an existing model with an existing XPath or do you create a new |
Hi Jan,
You can refer to the test case and data in #119.
From Yuwen's iPhone
在 2018年5月17日,下午4:33,Jan Koehnlein <notifications@github.com<mailto:notifications@github.com>> 写道:
Could you elaborate on the serialization usecase? Do you read in an existing model with an existing XPath or do you create a new UnparsedXpath? Is it in the SerializationIntegrationTest?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#118 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAxaKXTPr9zu4E5P2mkW_rzTJ3Nats9cks5tzYoogaJpZM4UC_zs>.
|
Depends on eclipse/xtext-core#747 |
Signed-off-by: Jan Koehnlein <jan.koehnlein@typefox.io>
GH-118 Preserve quotes on serialization
Fixed |
This issue has to be re-opened. |
GH-118 reopen issue: Take string concatenations into account
Fixed |
Unfortuantely, we found some other strange behaviors.
The space will make xpath totally wrong. |
Signed-off-by: Jan Koehnlein <jan.koehnlein@typefox.io>
Never mind. I've added the missing case and more tests. |
GH-118 also consider XpathNameTest elements
Hopefully fixed now. Don't hesitate to reopen if you encounter further pecularities. |
We recently found that all Quotes which used to wrap XpathExpression will be removed after serialization. For example, original,
leaf lf2 {
type uint8;
must '. <= ../lf1';
}
After serialization,
leaf lf2 {
type uint8;
must . <= ../lf1;
}
We double checked with RFC 7950, actually, it is valid according to the 'must' and 'when' definition.
But we still propose to wrap XpathExpression with Quotes, or at least keep as what it is. There are a few reasons,
The text was updated successfully, but these errors were encountered: