GH-154: Replaced the lists with sets for the xpath computations. #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@svenefftinge, can you please look into the changes? Thanks! |
| @@ -375,13 +375,13 @@ class XpathResolver { | |||
| } | |||
| return Types.nodeSet(nodes) | |||
| } | |||
| val result = newArrayList() | |||
| val result = newHashSet() | |||
There was a problem hiding this comment.
please use a linked hash set to preserve the order
svenefftinge
approved these changes
Nov 20, 2018
|
@huyuwen were you able to test the change against your models? |
As a quick solution for a performance issue when resolving complex long paths. Closes: #154. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
|
I have replaced the |
|
Not yet, I will do it ASAP. Sorry for delay.
Akos Kitta <notifications@github.com> 于2018年11月20日周二 上午10:46写道：
… I have replaced the HashSet with a LinkedHashSet.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#155 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAxaKWJOMHdfsiq406neSW861VZLW-omks5uw8-BgaJpZM4Ynkep>
.
|
|
I am merging this now. |
|
I just test locally with our own data. The solution works fine. Really thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a quick solution for a performance issue when resolving complex
long paths.
Closes: #154.