-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use new atom ide types #1559
use new atom ide types #1559
Conversation
@lierdakil When I run prettier nothing changes! Is this error a false-positive? |
Apparently prettier is broken on good ol' Trusty. I've just updated Travis config to use Bionic. It should (hopefully) work if you merge/rebase. |
36f0ac1
to
0a27a1c
Compare
Rebased it. Now it works 😄 |
0a27a1c
to
c142b2a
Compare
Can we have a types-only package? It feels somewhat weird to install something just for the types. Especially considering atom-ide-base npm package is 3.6M when the types we need are only 44K (i.e. about 1.2%) Yes, I know, common wisdom is to bundle types with the package. But here it's a bit different, since the absolute majority of |
Actually, I plan to add more functionalities to atom-ide-base. Since it is both an apm and an npm package. So in the near future, there will be some code that all the IDE packages would need to use. Many of the logics can be refactored in a commonplace. I can remove the modules folder, which includes the legacy nuclide. That's the part which takes the most space. This should not affect the end-user for now. It is just a devDependency. 🤔 Does it? We have bigger packages in the devDependencies now like parcel which has a post install that builds a native module! If this is going to be installed in a prod install, we have a bigger problem! |
It should not, unless something is very wrong, or the end-user decides they want to hack on the package. This is admittedly a minor nitpick.
Okay, cool, works for me. |
Merged manually due to conflicts. |
This uses the new atom-ide types which are provided in atom-ide-base.