Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow not existing files for external modules #27

Merged
merged 1 commit into from
Jan 12, 2016

Conversation

tolemac
Copy link
Contributor

@tolemac tolemac commented Dec 22, 2015

When process the external imports may be that the file don't exists, then when you access to the property "file" of exportMap item and get an error.

I think the first to do is to check externals parameters, if externals is false you haven't if the file is excluded, and if 'externals' is false It may be that the file does not exist then you have to check p to access to p.file.

I'm generating .d.ts for ng-forward project and I have been problems with reactive/rxjs import, with these changes work fine.

@basarat
Copy link
Member

basarat commented Jan 5, 2016

@tolemac This project is without owner. Would you be willing to take over?

@basarat
Copy link
Member

basarat commented Jan 5, 2016

/cc @vvakame for approval (I already have all the access to be able to transfer it) 🌹

@tolemac
Copy link
Contributor Author

tolemac commented Jan 5, 2016

@basarat I'm not sure about it. I don't have a lot of experience on open source projects. By the other hand this is a small project, may be a good start.
If I need help or have any problem in the future, can I ask you? If you say yes, I also.

@tolemac
Copy link
Contributor Author

tolemac commented Jan 6, 2016

According to autodts-generator readme TypeScript 1.8 implements the main goal of this project.
Is correct?

@basarat
Copy link
Member

basarat commented Jan 6, 2016

@tolemac indeed. Also there is https://github.com/SitePen/dts-generator that I now personally use. But lately, even simpler just going with node module resolution : https://basarat.gitbooks.io/typescript/content/docs/node/nodejs.html

Maybe it isn't sufficient for people, or maybe there isn't much education, nevertheless I haven't had the need for this project lately

@tolemac
Copy link
Contributor Author

tolemac commented Jan 9, 2016

I have been testing dts-generator and autodts and don't like them.
I like dts-bundle because it start from a d.ts file, don't need tsconfig.json and exports only that I want.

To have this pull request would be nice.

@basarat
Copy link
Member

basarat commented Jan 11, 2016

@tolemac I've added you as a collab here. Feel free to merge the PR and own this project 🌹

I also wrote one possible workflow you can follow : https://medium.com/@basarat/possible-workflow-for-npm-module-contribution-8e6b3c54f4e2#.hpeefm6mi 🌹 feel free to customize / ask for help.

Also added you as a collab on https://www.npmjs.com/package/dts-bundle 🌹

@basarat
Copy link
Member

basarat commented Jan 11, 2016

PS : sorry for the late reply 🌹

@tolemac
Copy link
Contributor Author

tolemac commented Jan 11, 2016

Ok. I get down to work ;)

tolemac added a commit that referenced this pull request Jan 12, 2016
Allow not existing files for external modules, closes #22, #25
@tolemac tolemac merged commit 1990fca into TypeStrong:master Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants