-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow not existing files for external modules #27
Conversation
@tolemac This project is without owner. Would you be willing to take over? |
/cc @vvakame for approval (I already have all the access to be able to transfer it) 🌹 |
@basarat I'm not sure about it. I don't have a lot of experience on open source projects. By the other hand this is a small project, may be a good start. |
According to autodts-generator readme TypeScript 1.8 implements the main goal of this project. |
@tolemac indeed. Also there is https://github.com/SitePen/dts-generator that I now personally use. But lately, even simpler just going with node module resolution : https://basarat.gitbooks.io/typescript/content/docs/node/nodejs.html Maybe it isn't sufficient for people, or maybe there isn't much education, nevertheless I haven't had the need for this project lately |
I have been testing dts-generator and autodts and don't like them. To have this pull request would be nice. |
@tolemac I've added you as a collab here. Feel free to merge the PR and own this project 🌹 I also wrote one possible workflow you can follow : https://medium.com/@basarat/possible-workflow-for-npm-module-contribution-8e6b3c54f4e2#.hpeefm6mi 🌹 feel free to customize / ask for help. Also added you as a collab on https://www.npmjs.com/package/dts-bundle 🌹 |
PS : sorry for the late reply 🌹 |
Ok. I get down to work ;) |
When process the external imports may be that the file don't exists, then when you access to the property "file" of exportMap item and get an error.
I think the first to do is to check
externals
parameters, ifexternals
is false you haven't if the file is excluded, and if 'externals' is false It may be that the file does not exist then you have to checkp
to access top.file
.I'm generating .d.ts for
ng-forward
project and I have been problems withreactive/rxjs
import, with these changes work fine.