Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v1.0.3 release #248

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Prepare v1.0.3 release #248

merged 2 commits into from
Apr 17, 2019

Conversation

johnnyreilly
Copy link
Member

@johnnyreilly johnnyreilly commented Apr 17, 2019

Release for #246

@johnnyreilly johnnyreilly merged commit 0cc9d8c into master Apr 17, 2019
@phryneas
Copy link
Contributor

phryneas commented Apr 17, 2019

Argh, bad timing :/
I just wanted to ask you to hold off this for a moment.

Context: I did some experimentation and I noticed that now, if an exception occurs in one of the worker processes, that exception now permeates towards the parent process in the form of an uncaught promise rejection.

Usually, that won't be a problem because usually a worker thread should not throw any exceptions, but I'd like to catch that & handle it gracefully.

@phryneas
Copy link
Contributor

I'll add a PR and some thorough information on this in a few minutes.

@phryneas
Copy link
Contributor

See #249

@piotr-oles piotr-oles deleted the johnnyreilly-patch-2 branch April 20, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants