Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.0.0 release #377

Merged
merged 19 commits into from
Jan 17, 2020
Merged

v4.0.0 release #377

merged 19 commits into from
Jan 17, 2020

Conversation

piotr-oles
Copy link
Collaborator

Changes:

  • Switch from class based NormalizedMessage to plain object Issue to improve code quality.
  • Drop multi-process mode to simplify code-base and focus more on optimizing single-process mode.
  • Drop watch paths option to simplify code-base and to switch to TypeScript API watcher
  • Drop support for webpack < 4.0 to simplify our codebase and prepare for further refactoring.
  • Drop support for the TsLint as it's deprecated and we want to simplify our code-base.

BREAKING CHANGES 🧨:

  • Dropped support for webpack 2.0 and webpack 3.0
  • Dropped support for TsLint
  • Dropped support for multi-process mode (removed workers option from
    plugin configuration, workersNumber argument from serviceStart hook
    and pre-computed consts: ONE_CPU, ALL_CPUS, ONE_CPU_FREE, TWO_CPUS_FREE)
  • Dropped support for watch paths option (removed watch option from
    the plugin-configuration and watchPaths argument from serviceStart
    hook)
  • Formatter will not receive second argument useColors - it should be handled automatically by the formatter (for example by using chalk)
  • Removed "tslint" and "tslintAutoFix" option
  • Removed "hasTslint" argument for the "waiting" plugin hook
  • Removed "tslintPath" argument for the "serviceStart" plugin hook
  • Removed colors option from the plugin settings,
  • Changed type from NormalizedMessage to Issue which is used by plugin hooks and formatters,

Switch from class based `NormalizedMessage` to plain object `Issue`
to improve code quality. All added files are 100% covered by tests.

BREAKING CHANGE 🧨 Removed `colors` option from the plugin settings,
BREAKING CHANGE 🧨 Changed type from NormalizedType to Issue which is used by plugin hooks and formatters,
BREAKING CHANGE 🧨 Formatter will not receive second argument `useColors` - it should be handled automatically by the formatter (for example by using `chalk`)
We drop multi-process mode to simplify code-base and focus more on
optimizing single-process mode.

BREAKING CHANGE: 🧨 Dropped support for multi-process mode (removed `workers` option from
plugin configuration, `workersNumber` argument from serviceStart hook
and pre-computed consts: ONE_CPU, ALL_CPUS, ONE_CPU_FREE, TWO_CPUS_FREE)
We drop watch paths option to simplify code-base and to switch to
TypeScript API watcher

BREAKING CHANGE: 🧨 Dropped support for `watch` paths option (removed `watch` option from
the plugin-configuration and `watchPaths` argument from serviceStart
hook)
We drop support for webpack < 4.0 to simplify our codebase and prepare for further refactoring.

BREAKING CHANGE: 🧨 Dropped support for webpack 2.0 and webpack 3.0
In order to simplify the release job, we want to switch to the `npx
semantic-release` command to skip dependencies installation
We drop support for the TsLint as it's deprecated and we want to
simplify our code-base.

BREAKING CHANGE: 🧨 Dropped support for TsLint
BREAKING CHANGE: 🧨 Removed "tslint" and "tslintAutoFix" option
BREAKING CHANGE: 🧨 Removed "hasTslint" argument for the "waiting" plugin hook
BREAKING CHANGE: 🧨 Removed "tslintPath" argument for the "serviceStart" plugin hook
@phryneas
Copy link
Contributor

I'm all for getting this out, but don't really have time for a proper review right now, sorry.

I guess if it's been running okay for both of you until now, let's just get it out :)

Copy link
Member

@johnnyreilly johnnyreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@piotr-oles piotr-oles merged commit 5008da9 into master Jan 17, 2020
@piotr-oles piotr-oles deleted the beta branch January 17, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants