-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.0.0 release #377
Merged
Merged
v4.0.0 release #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from class based `NormalizedMessage` to plain object `Issue` to improve code quality. All added files are 100% covered by tests. BREAKING CHANGE 🧨 Removed `colors` option from the plugin settings, BREAKING CHANGE 🧨 Changed type from NormalizedType to Issue which is used by plugin hooks and formatters, BREAKING CHANGE 🧨 Formatter will not receive second argument `useColors` - it should be handled automatically by the formatter (for example by using `chalk`)
We drop multi-process mode to simplify code-base and focus more on optimizing single-process mode. BREAKING CHANGE: 🧨 Dropped support for multi-process mode (removed `workers` option from plugin configuration, `workersNumber` argument from serviceStart hook and pre-computed consts: ONE_CPU, ALL_CPUS, ONE_CPU_FREE, TWO_CPUS_FREE)
We drop watch paths option to simplify code-base and to switch to TypeScript API watcher BREAKING CHANGE: 🧨 Dropped support for `watch` paths option (removed `watch` option from the plugin-configuration and `watchPaths` argument from serviceStart hook)
We drop support for webpack < 4.0 to simplify our codebase and prepare for further refactoring. BREAKING CHANGE: 🧨 Dropped support for webpack 2.0 and webpack 3.0
In order to simplify the release job, we want to switch to the `npx semantic-release` command to skip dependencies installation
We drop support for the TsLint as it's deprecated and we want to simplify our code-base. BREAKING CHANGE: 🧨 Dropped support for TsLint BREAKING CHANGE: 🧨 Removed "tslint" and "tslintAutoFix" option BREAKING CHANGE: 🧨 Removed "hasTslint" argument for the "waiting" plugin hook BREAKING CHANGE: 🧨 Removed "tslintPath" argument for the "serviceStart" plugin hook
…k-plugin into beta
I'm all for getting this out, but don't really have time for a proper review right now, sorry. I guess if it's been running okay for both of you until now, let's just get it out :) |
johnnyreilly
approved these changes
Jan 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
NormalizedMessage
to plain objectIssue
to improve code quality.BREAKING CHANGES 🧨:
workers
option fromplugin configuration,
workersNumber
argument from serviceStart hookand pre-computed consts: ONE_CPU, ALL_CPUS, ONE_CPU_FREE, TWO_CPUS_FREE)
watch
paths option (removedwatch
option fromthe plugin-configuration and
watchPaths
argument from serviceStarthook)
useColors
- it should be handled automatically by the formatter (for example by usingchalk
)colors
option from the plugin settings,