Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html2ts should honor outDir setting #271

Closed
hoeni opened this issue Aug 4, 2015 · 9 comments
Closed

html2ts should honor outDir setting #271

hoeni opened this issue Aug 4, 2015 · 9 comments
Labels

Comments

@hoeni
Copy link

hoeni commented Aug 4, 2015

When generating a .ts file from .html it should be stored in the configured outDir (if there is one configured).
At the moment, the .ts file is generated in the source directory, only the derived .js and .map files are stored in the outDir correctly.

If using outDir for that is not an option, maybe one could introduce a separate option for that (e.g. 'htmlOutDir')?

@davidLeonardi
Copy link
Contributor

Valid point. I personally don't use outDir so it hadn't occured to me that this may be necessary, but I'll make changes to honor outDir.

@davidLeonardi
Copy link
Contributor

Btw, i just checked the source, and "htmlOutDir" is already a valid option.

@hoeni
Copy link
Author

hoeni commented Aug 4, 2015

At least "htmlOutDir" has no effect in my case...

@davidLeonardi
Copy link
Contributor

I'll test it later this week. Thx for reporting!

On Tue, Aug 4, 2015 at 2:20 PM Tobias Henöckl notifications@github.com
wrote:

At least "htmlOutDir" has no effect in my case...


Reply to this email directly or view it on GitHub
#271 (comment)
.

@nycdotnet
Copy link
Contributor

This will be fixed in #275 when that is complete (still work-in-progress).

@nycdotnet
Copy link
Contributor

Hello, @hoeni - Would you please try grunt-ts@5.0.0-beta.2 and let me know if it resolves your issue? Please note that this is a significant rewrite of the options resolution logic so it may have other issues. Let me know if you see anything.

@nycdotnet
Copy link
Contributor

This should be corrected in v5, just released to npm. Please reopen if not.

@hoeni
Copy link
Author

hoeni commented Oct 8, 2015

Sorry, I didn't find the time yet to test it yet. I'll reopen if there are any issues!

@nycdotnet
Copy link
Contributor

No worries! Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants