Merge pull request #951 from andrewbranch/bug/950

Don’t try to resolve project references if project references are disabled in loader options

src/config.ts

@@ -127,14 +127,19 @@ export function getConfigParseResult(
   compiler: typeof typescript,
   configFile: ConfigFile,
   basePath: string,
-  configFilePath: string | undefined
+  configFilePath: string | undefined,
+  enableProjectReferences: boolean
 ) {
   const configParseResult = compiler.parseJsonConfigFileContent(
     configFile.config,
     compiler.sys,
     basePath
   );
 
+  if (!enableProjectReferences) {
+    configParseResult.projectReferences = undefined;
+  }
+
   if (semver.gte(compiler.version, '3.5.0')) {
     // set internal options.configFilePath flag on options to denote that we read this from a file
     configParseResult.options = Object.assign({}, configParseResult.options, {

src/instances.ts

@@ -100,7 +100,8 @@ function successfulTypeScriptInstance(
     compiler,
     configFile,
     basePath,
-    configFilePath
+    configFilePath,
+    loaderOptions.projectReferences
   );
 
   if (configParseResult.errors.length > 0 && !loaderOptions.happyPackMode) {

test/execution-tests/3.0.1_projectReferencesDisabled/karma.conf.js

@@ -0,0 +1,17 @@
+/* eslint-disable no-var, strict */
+'use strict';
+var webpackConfig = require('./webpack.config.js');
+var makeKarmaConfig = require('../../karmaConfig');
+
+module.exports = function(config) {
+  config.set(
+    makeKarmaConfig({
+      config,
+      webpackConfig,
+      files: [
+        // This ensures we have the es6 shims in place from babel and then loads all the tests
+        'main.js'
+      ]
+    })
+  );
+};

test/execution-tests/3.0.1_projectReferencesDisabled/lib/.gitignore

@@ -0,0 +1 @@
+!*.js.map

test/execution-tests/3.0.1_projectReferencesDisabled/lib/index.d.ts

@@ -0,0 +1,5 @@
+export declare const lib: {
+    one: number;
+    two: number;
+    three: number;
+};

test/execution-tests/3.0.1_projectReferencesDisabled/lib/index.ts

@@ -0,0 +1,5 @@
+export const lib = {
+  one: 1,
+  two: 2,
+  three: 3
+};

test/execution-tests/3.0.1_projectReferencesDisabled/lib/tsconfig.json

@@ -0,0 +1,9 @@
+{
+  "compilerOptions": {
+    "composite": true,
+    "sourceMap": true
+  },
+  "files": [
+    "./index.ts"
+  ]
+}

test/execution-tests/3.0.1_projectReferencesDisabled/main.js

@@ -0,0 +1,2 @@
+const testsContext = require.context('./', true, /\.tests\.ts(x?)$/);
+testsContext.keys().forEach(testsContext);

test/execution-tests/3.0.1_projectReferencesDisabled/package.json

@@ -0,0 +1,10 @@
+{
+  "name": "basic",
+  "license": "MIT",
+  "version": "1.0.0",
+  "main": "index.js",
+  "devDependencies": {
+    "@types/jasmine": "^2.5.35",
+    "jasmine-core": "^2.3.4"
+  }
+}

test/execution-tests/3.0.1_projectReferencesDisabled/src/app.ts

@@ -0,0 +1,5 @@
+import { lib } from '../lib';
+
+export function whatNumbersDoYouHave() {
+    return [lib.one, lib.two, lib.three];
+}

test/execution-tests/3.0.1_projectReferencesDisabled/test/app.tests.ts

@@ -0,0 +1,7 @@
+import { whatNumbersDoYouHave } from "../src/app";
+
+describe("app", () => {
+  it("code compiled using projectReferences can be consumed", () => {
+    expect(whatNumbersDoYouHave()).toEqual([1, 2, 3]);
+  });
+});

test/execution-tests/3.0.1_projectReferencesDisabled/tsconfig.json

@@ -0,0 +1,11 @@
+{
+  "files": [
+    "./src/app.ts"
+  ],
+  "references": [
+    { "path": "./lib" }
+  ],
+  "compilerOptions": {
+    "noEmitOnError": true
+  }
+}

test/execution-tests/3.0.1_projectReferencesDisabled/webpack.config.js

@@ -0,0 +1,18 @@
+module.exports = {
+    mode: 'development',
+    entry: './src/app.ts',
+    output: {
+        filename: 'bundle.js'
+    },
+    resolve: {
+        extensions: ['.ts', '.js']
+    },
+    module: {
+        rules: [
+            { test: /\.ts$/, loader: 'ts-loader', options: { projectReferences: false } }
+        ]
+    }
+}
+
+// for test harness purposes only, you would not need this in a normal project
+module.exports.resolveLoader = { alias: { 'ts-loader': require('path').join(__dirname, "../../../index.js") } }

test/execution-tests/3.0.1_projectReferencesDisabled/yarn.lock

@@ -0,0 +1,13 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
+
+
+"@types/jasmine@^2.5.35":
+  version "2.8.5"
+  resolved "https://registry.yarnpkg.com/@types/jasmine/-/jasmine-2.8.5.tgz#96e58872583fa80c7ea0dd29024b180d5e133678"
+  integrity sha512-mkrHFZTgOXkZhau36K628iKFkjbp11t/bHCkY4Mefu4R6McMg2FD9P3naBv/0Ygyn4sz8baColJp2gdmSekgiw==
+
+jasmine-core@^2.3.4:
+  version "2.9.1"
+  resolved "https://registry.yarnpkg.com/jasmine-core/-/jasmine-core-2.9.1.tgz#b6bbc1d8e65250d56f5888461705ebeeeb88f22f"
+  integrity sha1-trvB2OZSUNVvWIhGFwXr7uuI8i8=