Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t try to resolve project references if project references are disabled in loader options #951

Merged
merged 2 commits into from
Jun 10, 2019

Conversation

andrewbranch
Copy link
Contributor

Fixes #950

Execution test is identical to 3.0.1_projectReferences except for the Webpack loader config.

@johnnyreilly
Copy link
Member

Great work!

@andrewbranch andrewbranch merged commit f667bb5 into TypeStrong:master Jun 10, 2019
@andrewbranch
Copy link
Contributor Author

It seems like there are a couple other things close to going in, and apparently I'm the only person that found this bug and cared to report it, so I'm ok with holding off on a release if you are—up to you.

@andrewbranch andrewbranch deleted the bug/950 branch June 10, 2019 16:24
@johnnyreilly
Copy link
Member

Cool with me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants