Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prettier screenshot #710

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Add prettier screenshot #710

merged 1 commit into from
Oct 19, 2018

Conversation

abraham
Copy link
Contributor

@abraham abraham commented Oct 19, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.906% when pulling 37db12d on abraham:update-screenshot into ebe239a on TypeStrong:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.906% when pulling 37db12d on abraham:update-screenshot into ebe239a on TypeStrong:master.

@coveralls
Copy link

coveralls commented Oct 19, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 84.906% when pulling bb797cf on abraham:update-screenshot into ebe239a on TypeStrong:master.

@blakeembrey
Copy link
Member

Looks neat! Quick heads up (and my fault):

  1. --type-check is the default again, not needed as a flag
  2. It looks like there's a rendering overlap issue in the screenshot with the error message?

@abraham
Copy link
Contributor Author

abraham commented Oct 19, 2018

Fixed.

@blakeembrey blakeembrey merged commit 132e569 into TypeStrong:master Oct 19, 2018
@abraham abraham deleted the update-screenshot branch October 19, 2018 03:26
@fbjork
Copy link

fbjork commented May 12, 2019

@abraham what terminal theme is that? Looks nice.

@abraham
Copy link
Contributor Author

abraham commented May 13, 2019

@fbjork I think it was the default Seti on https://carbon.now.sh/

@cspotcode cspotcode mentioned this pull request Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abraham @coveralls @blakeembrey @fbjork