Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TS version #655

Closed
chriskrycho opened this issue Dec 4, 2017 · 2 comments
Closed

Upgrade TS version #655

chriskrycho opened this issue Dec 4, 2017 · 2 comments

Comments

@chriskrycho
Copy link

Since TypeDoc hooks into the TS version, it can be quite frustrating to use when it's behind by several versions.

I have it running as a pre-commit hook via husky, and it's currently failing because I have intentionally (for the sake of the shape of my exports in the index.ts) imported some unused items. In TS 2.6 I can ignore those unused items by doing // @ts-ignore on the preceding line; but TypeDoc being only at 2.4 can't do that.

Related: is the underlying API being used so unstable that TypeDoc can't treat TS as a peer dependency rather than a direct dependency? It would be great if it was a peer dep with a version requirement for >= whatever the minimum version it needs is.

@aciccarello
Copy link
Collaborator

@chriskrycho, PR #654 should update the TS version in master. Once that is merged and a release is made the // @ts-ignore issue should be resolved.

As to why we can't use peer dependencies, TypeDoc currently relies on some internal TS APIs so it is very unstable. It'd be great if the project could move away from those but that seems like a significant undertaking.

Related #369

@chriskrycho
Copy link
Author

chriskrycho commented Dec 4, 2017 via email

aciccarello added a commit that referenced this issue Feb 1, 2018
classes example modified because accessing abstract properties is not allowed in the constructor

closes #654
closes #655
closes #681
closes #687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants