Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output source files and lines to JSON #266

Merged
merged 1 commit into from
Aug 18, 2016

Conversation

tmeasday
Copy link

@tmeasday tmeasday commented Aug 4, 2016

This commit ensures that the json dump includes information about source locations.

@blakeembrey
Copy link
Member

FWIW, this coding style is kind of terrible but since it matches the existing style I'll merge it as is. The preferred way to write this would be using Array#map.

@blakeembrey blakeembrey merged commit 6f4e366 into TypeStrong:master Aug 18, 2016
@aciccarello
Copy link
Collaborator

@blakeembrey, the entire codebase probably should be reviewed and a tslint configuration added. It would be a lot of work but possibly a good way to someone who wants to take on #256 to get a good handle on the codebase.

@blakeembrey
Copy link
Member

Absolutely, I agree - there's a lot I'd love to refactor - it's just not in a state where I can actively maintain it. The codebase is takes advantage of too much fanciness for me to focus on how it actually works (decorators, indirect dependencies, etc). I can get a gist, but without rewriting I'm not comfortable maintaining it myself right now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants