Upgrade typescript to v3.1.x #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. We'll need to figure out why the CI failed on Node 6 before merging. ❤️ |
Not that it helps a lot, but with Node 6, running the tests locally on a fresh clone of master gives me the same failing tests as this branch. |
|
There were failing tests on another PR that made a minor change so it is possible that it is a problem with the CI. I'll need to investigate but I hope to merge this this week. |
|
Tested locally with no issues |
|
Wonderful! Do you have an ETA for the npm update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the TypeScript dependency to the latest stable v3.1.x version (currently v3.1.1).